Merge pull request #219 from quarckster/selenium4

Bumped python version and changed selenium endpoint in the tests
RedHatQE · Apr 28, 2022 · 91dff8e · 91dff8e
2 parents 145df9c + d2839c6
commit 91dff8e
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 17 deletions.
diff --git a/.github/workflows/test_suite.yml b/.github/workflows/test_suite.yml
@@ -15,10 +15,10 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Setup Python
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v3
         with:
           python-version: "3.8"
           architecture: "x64"
@@ -30,15 +30,14 @@ jobs:
         if: failure()
         run: git diff
 
-  unit-tests:
+  tests:
     # Run unit tests on different version of python and browser
     name: 🐍 Python-${{ matrix.python-version }}-${{ matrix.browser }}
     runs-on: ubuntu-20.04
-    needs: [codechecks]
     strategy:
       matrix:
         browser: [chrome, firefox]
-        python-version: [3.8, 3.9]
+        python-version: ["3.8", "3.9", "3.10"]
 
     steps:
       - name: Pull selenium-standalone:latest
@@ -48,10 +47,10 @@ jobs:
         run: podman pull docker.io/library/nginx:alpine
 
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Set up Python-${{ matrix.python-version }}
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v3
         with:
           python-version: ${{ matrix.python-version }}
 
@@ -75,14 +74,13 @@ jobs:
 
   docs:
     name: Docs Build
-    needs: [unit-tests]
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Setup Python
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v3
         with:
           python-version: "3.8"
 
@@ -103,18 +101,17 @@ jobs:
   platform:
     # Check package properly install on different platform (dev setup)
     name: 💻 Platform-${{ matrix.os }}
-    needs: [unit-tests]
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Setup Python
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v3
         with:
           python-version: "3.8"
           architecture: "x64"
@@ -128,15 +125,14 @@ jobs:
 
   package:
     name: ⚙️ Build & Verify Package
-    needs: [unit-tests]
     runs-on: ubuntu-latest
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Setup Python
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v3
         with:
           python-version: "3.8"
           architecture: "x64"

diff --git a/setup.cfg b/setup.cfg
@@ -13,6 +13,8 @@ classifiers =
     Programming Language :: Python
     Programming Language :: Python :: 3
     Programming Language :: Python :: 3.8
+    Programming Language :: Python :: 3.9
+    Programming Language :: Python :: 3.10
     Programming Language :: Python :: Implementation :: CPython
     Programming Language :: Python :: Implementation :: PyPy
     Topic :: Software Development :: Libraries :: Python Modules

diff --git a/testing/conftest.py b/testing/conftest.py
@@ -65,7 +65,7 @@ def selenium_url(pytestconfig, worker_id, podman, pod):
         name=f"selenium_{worker_id}",
     )
     container.start()
-    yield f"http://{localhost_for_worker}:4444/wd/hub"
+    yield f"http://{localhost_for_worker}:4444"
     container.remove(force=True)