Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adds fixes for KICS warnings #80

Merged
merged 1 commit into from
Nov 9, 2023
Merged

chore: adds fixes for KICS warnings #80

merged 1 commit into from
Nov 9, 2023

Conversation

jpower432
Copy link
Member

Description

Adds fixes for KICS warning and adds a check to fail the KICS check on high.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  • make test-slow

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 requested a review from afflom November 7, 2023 03:12
@afflom afflom merged commit 016438d into RedHatProductSecurity:main Nov 9, 2023
7 checks passed
@jpower432 jpower432 deleted the chore/kics-fixes branch March 26, 2024 13:51
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afflom afflom afflom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpower432 @afflom