Fixed for build-time container image SBOMs #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprpic
reviewed
Sep 11, 2024
| for purl_ref in [ref for ref in pkg.get("externalRefs", []) if ref["referenceType"] == "purl"]: | ||
| purl = PackageURL.from_string(purl_ref["referenceLocator"]) | ||
| if purl.type == "oci": | ||
| purl.qualifiers.pop("tag", None) |
There was a problem hiding this comment.
Is the tag always known at build time? I was under the impression that it was created at release time.
There was a problem hiding this comment.
@twaugh Any thoughts on ^^^?
| ] | ||
| print(f"Described: {described}\nVariants: {variants}") | ||
| built = described + variants | ||
| for pkg in [pkg for pkg in sbom["packages"] if pkg["SPDXID"] in built]: |
There was a problem hiding this comment.
I'm not sure I understand this change. Is this just trying to filter down the packages to those that might represent images? Would there be other packages not using either DESCRIBES or VARIANT_OF that would be of type oci?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.