Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nessus e2e test #259

Merged
merged 21 commits into from
Nov 19, 2024
Merged

Nessus e2e test #259

merged 21 commits into from
Nov 19, 2024

Conversation

sfowl
Copy link
Collaborator

@sfowl sfowl commented Nov 15, 2024

early testing, will likely fail

Ready for review:

  • Runs a nessus integration test in a separate EaaS namespace. This test runs in parallel with the existing e2e tests.
  • Test depends on a private container-ized version of nessus at quay.io/sfowler/nessus. A pull secret is required to access this, and this is also created in the Konflux workspace. It is copied to the ephemeral EaaS namespace as part of the test pipeline
  • This also includes a switch to a forked version of py-nessus-pro which does not use selenium for authentication. This reduces startup time, which previously would pull in binaries for chrome on first run
  • Also re-organizes some of the test code. Most notable change is that each test will teardown the created k8s resources after that test completes, whereas previously this would be done for all possible resources at the completion of the entire test suite run. The newer approach makes it possible to run each test in parallel, as long as they don't share any k8s resources

@sfowl sfowl self-assigned this Nov 15, 2024
@sfowl sfowl marked this pull request as ready for review November 19, 2024 06:07
@sfowl sfowl requested a review from a team as a code owner November 19, 2024 06:07
@sfowl sfowl changed the title WIP: Nessus e2e test Nessus e2e test Nov 19, 2024
Copy link
Collaborator

@jeremychoi jeremychoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfowl sfowl merged commit c4f9314 into development Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants