-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSIDB-3712: Create container image #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costaconrado
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
C-Valen
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
superbuggy
reviewed
Nov 21, 2024
superbuggy
reviewed
Nov 21, 2024
superbuggy
reviewed
Nov 21, 2024
MrMarble
force-pushed
the
OSIDB-3712
branch
2 times, most recently
from
November 22, 2024 16:29
afbec58
to
450c81f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to improve the Docker-based CI/CD pipeline for running tests, including updates to the Docker configuration, scripts, and test settings.
Docker Configuration and Scripts:
.dockerignore
file to exclude unnecessary files from the Docker build context.Dockerfile
to set up the environment for running tests, including installing dependencies and configuring Kerberos authentication.auth.sh
script for Kerberos authentication within the container.install-certs.sh
script to install Red Hat certificates if theRH_CERT_URL
environment variable is set.krb5.conf
configuration file for Kerberos..gitignore
to thekrb5.conf.d
directory.Documentation:
README.md
file in thedocker
directory to provide instructions on building and running the Docker container, as well as running tests within the container.Test Configuration:
package.json
to simplify test scripts and remove unnecessary dependencies. [1] [2]playwright.config.ts
to use different reporters based on the CI environment.tests/flaw.spec.ts
to improve reliability. [1] [2]Closes OSIDB-3712