fix Bugzilla flaw summary exceeding #784
Open
+107
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmonzonis
requested changes
Oct 21, 2024
Comment on lines
+33
to
+36
| if len(description) <= len(MULTIPLE_DESCRIPTIONS_SUBSTITUTION): | ||
| raise UnsavableModelError( | ||
| f"Summary generated for the tracker is longer than {MAX_SUMMARY_LENGTH}" | ||
| ) |
There was a problem hiding this comment.
I know this is copied from old code, but we can move this to the top of the function. We avoid doing the operations on the cves array and remove this else clause making the code cleaner too.
Comment on lines
+263
to
+273
| while True: | ||
|
|
||
| cve_string = " ".join(cve_ids) + " " if cve_ids else "" | ||
| summary = f"{embargoed}{cve_string}{components}{description}" | ||
|
|
||
| if len(summary) <= MAX_SUMMARY_LENGTH: | ||
| break | ||
|
|
||
| cve_ids, description = summary_shorten(cve_ids, description) | ||
|
|
||
| self._query["summary"] = summary |
There was a problem hiding this comment.
If we have a long list of components, we may reach a point when summary_shorten can't shorten cve_ids and description further but we are still over the limit, ending in an infinite loop.
It might be a good idea to use a variable to keep track of whether we are still reducing the length at each step, and if we reach the limit (length is not reducing anymore but we are still over the max length) just exit the loop and shorten it the barbarian way
summary = summary[:MAX_SUMMARY_LENGTH-3] + "..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes OSIDB-3551