-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build copr rpm #45
Build copr rpm #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me. I think the whole build srpm and push rpms should be automated via github actions and the release process to COPR should be documented. Currently when we do a new release+tag in github it triggers the proccess which builds and pushes the new version of package in PYPI so this could be extended so new COPR version is released as well. We don't have to do it now, but at least documenting how to use the new scripts and add them to the release process docs.
Fedora COPR can build the package based on a git tag event. I think that might be the best way to go as then we won't need to keep Fedora credentials in Github. I'll try and set it up and then document the procedure here. I can grant access to admin the repository in COPR to other Fedora users. So if you setup a Fedora user account please request access to the repository here: https://copr.fedorainfracloud.org/coprs/jazinner/osidb-bindings/permissions/ |
983c7a4
to
1c84d2b
Compare
I have now setup the build to trigger on Github repo tag events. The RPM version will be in-sync with the PYPI version via the release.sh script. |
Thanks for the explanation. Sounds good to me. I've already requested access to the repository. Thanks! |
Approving, just one more thing. Please if you could add the RPM installation method here: |
This is working for Fedora 38-40 builds now, see https://copr.fedorainfracloud.org/coprs/jazinner/osidb-bindings/build/7494516/
However I had to adjust the project name in setup.py from osidb-bindings to osidb_bindings. I guess that will have an impact on the existing Pypi package.
@JakubFrejlach @JimFuller-RedHat please review.