Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build copr rpm #45

Merged
merged 2 commits into from
May 29, 2024
Merged

Build copr rpm #45

merged 2 commits into from
May 29, 2024

Conversation

jasinner
Copy link
Collaborator

This is working for Fedora 38-40 builds now, see https://copr.fedorainfracloud.org/coprs/jazinner/osidb-bindings/build/7494516/

However I had to adjust the project name in setup.py from osidb-bindings to osidb_bindings. I guess that will have an impact on the existing Pypi package.

@JakubFrejlach @JimFuller-RedHat please review.

Copy link
Collaborator

@JakubFrejlach JakubFrejlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me. I think the whole build srpm and push rpms should be automated via github actions and the release process to COPR should be documented. Currently when we do a new release+tag in github it triggers the proccess which builds and pushes the new version of package in PYPI so this could be extended so new COPR version is released as well. We don't have to do it now, but at least documenting how to use the new scripts and add them to the release process docs.

osidb_bindings.spec Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
@jasinner
Copy link
Collaborator Author

Generally looks good to me. I think the whole build srpm and push rpms should be automated via github actions and the release process to COPR should be documented. Currently when we do a new release+tag in github it triggers the proccess which builds and pushes the new version of package in PYPI so this could be extended so new COPR version is released as well. We don't have to do it now, but at least documenting how to use the new scripts and add them to the release process docs.

Fedora COPR can build the package based on a git tag event. I think that might be the best way to go as then we won't need to keep Fedora credentials in Github. I'll try and set it up and then document the procedure here. I can grant access to admin the repository in COPR to other Fedora users. So if you setup a Fedora user account please request access to the repository here: https://copr.fedorainfracloud.org/coprs/jazinner/osidb-bindings/permissions/

@jasinner jasinner force-pushed the build-copr-rpm branch 12 times, most recently from 983c7a4 to 1c84d2b Compare May 28, 2024 05:35
@jasinner
Copy link
Collaborator Author

I have now setup the build to trigger on Github repo tag events. The RPM version will be in-sync with the PYPI version via the release.sh script.

@JakubFrejlach
Copy link
Collaborator

Generally looks good to me. I think the whole build srpm and push rpms should be automated via github actions and the release process to COPR should be documented. Currently when we do a new release+tag in github it triggers the proccess which builds and pushes the new version of package in PYPI so this could be extended so new COPR version is released as well. We don't have to do it now, but at least documenting how to use the new scripts and add them to the release process docs.

Fedora COPR can build the package based on a git tag event. I think that might be the best way to go as then we won't need to keep Fedora credentials in Github. I'll try and set it up and then document the procedure here. I can grant access to admin the repository in COPR to other Fedora users. So if you setup a Fedora user account please request access to the repository here: https://copr.fedorainfracloud.org/coprs/jazinner/osidb-bindings/permissions/

Thanks for the explanation. Sounds good to me. I've already requested access to the repository. Thanks!

@JakubFrejlach
Copy link
Collaborator

I have now setup the build to trigger on Github repo tag events. The RPM version will be in-sync with the PYPI version via the release.sh script.

Approving, just one more thing. Please if you could add the RPM installation method here:
https://github.com/RedHatProductSecurity/osidb-bindings/blob/master/TUTORIAL.md#installation

@jasinner jasinner merged commit 69b3a47 into master May 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants