Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds support for rules in YAML format #54

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Oct 12, 2023

What has changed?

  • Removes CSV based rule examples
  • Removes CSV automation for rules
  • Adds action to auto-transform when the YAML is edited
  • Adds doc to expand on design of existing and new workflows.

How was this tested?

Tested in a PR on my fork jpower432#5

@jpower432 jpower432 force-pushed the PSCE-236 branch 3 times, most recently from 5b12ab6 to b07dcb0 Compare October 12, 2023 19:18
@jpower432 jpower432 marked this pull request as ready for review October 12, 2023 19:38
@jpower432 jpower432 requested a review from a team as a code owner October 12, 2023 19:38
@jpower432
Copy link
Member Author

jpower432 commented Oct 12, 2023

@afflom For your review, the last error was expected since we don't support forks, but we could add a task in the backlog to detect this and error a bit more gracefully. Just added a skip for now.

Removes CSV based rule examples
Removes CSV automation for rules

Adds action to auto-transform adhoc and when the YAML is edited

Adds a concurrency group to make sure branch modifying worflow are not run that the same time

Signed-off-by: Jennifer Power <[email protected]>
Adds concurrency group to ensure checks are not
run concurrently for the same branch

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 marked this pull request as ready for review October 17, 2023 23:10
@jpower432 jpower432 requested a review from afflom October 17, 2023 23:10
@afflom afflom merged commit c9de230 into RedHatProductSecurity:main Oct 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants