Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

GRIF-163: Dependency pinning #268

Merged
merged 4 commits into from
Nov 22, 2023
Merged

GRIF-163: Dependency pinning #268

merged 4 commits into from
Nov 22, 2023

Conversation

JakubFrejlach
Copy link
Collaborator

This PR:

  • migrates setup.py to pyproject.toml to by PEP 621 compliant
  • pins component-registry-bindings and osidb-bindings dependencies in pyproject.toml

@JakubFrejlach JakubFrejlach self-assigned this Nov 20, 2023
@JakubFrejlach
Copy link
Collaborator Author

Need to figure out PEP 517 problems in pipelines

JimFuller-RedHat
JimFuller-RedHat approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@JimFuller-RedHat JimFuller-RedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JakubFrejlach
Migrate from setup.py to pyproject.toml
9ed9854 
To comply with PEP 621
@JakubFrejlach
Update and pin bindings dependencies
b99fc74 
Update in both requirements .txt files and in pyproject.toml
Newly pinned in pyproject.toml
@JakubFrejlach JakubFrejlach merged commit 83a7f94 into main Nov 22, 2023
4 checks passed
@JakubFrejlach JakubFrejlach mentioned this pull request Dec 5, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JimFuller-RedHat JimFuller-RedHat JimFuller-RedHat approved these changes

Assignees

@JakubFrejlach JakubFrejlach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JakubFrejlach @JimFuller-RedHat