Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(APIv2): expose the TOML format of the tailoring_file #2267

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

skateman
Copy link
Member

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@skateman skateman requested a review from a team as a code owner October 24, 2024 04:40
@skateman skateman force-pushed the toml-tailoring branch 5 times, most recently from cf3ab4e to 84ee11d Compare October 24, 2024 07:56
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.86%. Comparing base (9f15e4c) to head (9baebbc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2267   +/-   ##
=======================================
  Coverage   98.85%   98.86%           
=======================================
  Files         235      237    +2     
  Lines        5149     5193   +44     
=======================================
+ Hits         5090     5134   +44     
  Misses         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skateman skateman force-pushed the toml-tailoring branch 2 times, most recently from 1ffed64 to 3a5509b Compare October 24, 2024 08:29
Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@skateman skateman merged commit 8e241e9 into RedHatInsights:master Oct 24, 2024
13 checks passed
@skateman skateman deleted the toml-tailoring branch October 24, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants