fix(ci): update build_deploy to correctly generate sc tagged images

[casey-williams-rh]

Overview

This update changes the following to properly generate the SC IMAGE TAG when building off of the security-compliance branch.

Secure Coding Practices Checklist GitHub Link

• https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

• Input Validation
• Output Encoding
• Authentication and Password Management
• Session Management
• Access Control
• Cryptographic Practices
• Error Handling and Logging
• Data Protection
• Communication Security
• System Configuration
• Database Security
• File Management
• Memory Management
• General Coding Practices

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.85%. Comparing base (e329757) to head (b53e49a).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2240   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files         235      235           
  Lines        5149     5149           
=======================================
  Hits         5090     5090           
  Misses         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[petrblaho]

@casey-williams-rh can you explain, what was wrong with that? also, if it is not working, shouldn't we update the same code in the non sc-* branch of if block too?

[casey-williams-rh]

Hey @petrblaho , so when using export CICD_IMAGE_BUILDER_BUILD_ARGS=("IMAGE_TAG=$SECURITY_COMPLIANCE_TAG") the IMAGE_TAG parameter evaluates as empty "". So I have defined IMAGE_TAG manually as opposed to relying on the CICD_IMAGE_BUILDER_BUILD_ARGS.