Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CI): RHCLOUD-26746 Replace build-deploy-common library #1819

Merged
merged 9 commits into from
Nov 2, 2023
Merged

fix(CI): RHCLOUD-26746 Replace build-deploy-common library #1819

merged 9 commits into from
Nov 2, 2023

Conversation

Victoremepunto
Copy link
Contributor

@Victoremepunto Victoremepunto commented Sep 21, 2023 •
edited by romanblanco
Loading

https://github.com/RedHatInsights/cicd-tools/tree/aeb9fe8b13b4a5524014ada4b0d324020dd04289

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@Victoremepunto Victoremepunto force-pushed the refactor-build-deploy.sh branch 6 times, most recently from 46e96e9 to 1c4bca7 Compare September 21, 2023 09:49
@Victoremepunto Victoremepunto force-pushed the refactor-build-deploy.sh branch 7 times, most recently from 827799f to 5f295dd Compare October 20, 2023 14:20
@Victoremepunto Victoremepunto marked this pull request as ready for review October 30, 2023 10:30
@Victoremepunto Victoremepunto requested a review from a team as a code owner October 30, 2023 10:30
@Victoremepunto
Copy link
Contributor Author

/retest

@romanblanco romanblanco changed the title Replace build-deploy-common library fix(CI): RHCLOUD-26746 Replace build-deploy-common library Oct 31, 2023
romanblanco
romanblanco approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@romanblanco romanblanco merged commit 7ccb587 into RedHatInsights:master Nov 2, 2023
7 checks passed
@Victoremepunto Victoremepunto deleted the refactor-build-deploy.sh branch November 2, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman left review comments

@romanblanco romanblanco romanblanco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Victoremepunto @skateman @romanblanco