-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CI): RHCLOUD-26746 Replace build-deploy-common library #1819
Merged
romanblanco
merged 9 commits into
RedHatInsights:master
from
Victoremepunto:refactor-build-deploy.sh
Nov 2, 2023
Merged
fix(CI): RHCLOUD-26746 Replace build-deploy-common library #1819
romanblanco
merged 9 commits into
RedHatInsights:master
from
Victoremepunto:refactor-build-deploy.sh
Nov 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
Victoremepunto
force-pushed
the
refactor-build-deploy.sh
branch
6 times, most recently
from
September 21, 2023 09:49
46e96e9
to
1c4bca7
Compare
Victoremepunto
force-pushed
the
refactor-build-deploy.sh
branch
7 times, most recently
from
October 20, 2023 14:20
827799f
to
5f295dd
Compare
Victoremepunto
force-pushed
the
refactor-build-deploy.sh
branch
from
October 30, 2023 07:42
5f295dd
to
bd7c031
Compare
/retest |
Victoremepunto
force-pushed
the
refactor-build-deploy.sh
branch
from
October 30, 2023 10:31
bd7c031
to
92cd49b
Compare
romanblanco
changed the title
Replace build-deploy-common library
fix(CI): RHCLOUD-26746 Replace build-deploy-common library
Oct 31, 2023
romanblanco
reviewed
Oct 31, 2023
Co-authored-by: Roman Blanco <[email protected]>
Victoremepunto
force-pushed
the
refactor-build-deploy.sh
branch
from
November 2, 2023 07:42
c6ef58c
to
2b7f353
Compare
romanblanco
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/RedHatInsights/cicd-tools/tree/aeb9fe8b13b4a5524014ada4b0d324020dd04289
Secure Coding Practices Checklist GitHub Link
Secure Coding Checklist