Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(APIv2): RHINENG-2133 implement rules endpoint nested under profiles #1818

Merged
merged 1 commit into from
Oct 10, 2023
Merged

feat(APIv2): RHINENG-2133 implement rules endpoint nested under profiles #1818

merged 1 commit into from
Oct 10, 2023

Conversation

RoamingNoMaD
Copy link
Contributor

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
app/models/v2/profile_rule.rb 100.00% <100.00%> (ø)
app/models/v2/rule.rb 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@romanblanco romanblanco added the APIv2 REST API v2 label Sep 22, 2023
@RoamingNoMaD RoamingNoMaD force-pushed the profiles-rules-endpoint branch 3 times, most recently from ac456e0 to 0b23224 Compare October 2, 2023 15:29
@skateman skateman marked this pull request as ready for review October 10, 2023 19:07
@skateman skateman requested a review from a team as a code owner October 10, 2023 19:07
skateman
skateman approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@skateman skateman enabled auto-merge (rebase) October 10, 2023 19:14
@skateman skateman merged commit af7382f into RedHatInsights:master Oct 10, 2023
8 checks passed
@RoamingNoMaD RoamingNoMaD deleted the profiles-rules-endpoint branch February 9, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

Assignees
No one assigned
Labels
APIv2 REST API v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RoamingNoMaD @skateman @romanblanco