Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(REST): RHICOMPL-3904 generate APIv2 spec #1765

Merged
merged 1 commit into from
Sep 22, 2023
Merged

feat(REST): RHICOMPL-3904 generate APIv2 spec #1765

merged 1 commit into from
Sep 22, 2023

Conversation

romanblanco
Copy link
Member

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited
Loading

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@romanblanco romanblanco force-pushed the RHICOMPL-3904-rswag-v2-init branch 3 times, most recently from bfce991 to fd57718 Compare August 4, 2023 12:33
@skateman
Copy link
Member

skateman commented Aug 4, 2023

There should be a symlink in the public folder (see for v1 as an inspiration)

@romanblanco romanblanco added the APIv2 REST API v2 label Aug 7, 2023
@romanblanco romanblanco force-pushed the RHICOMPL-3904-rswag-v2-init branch 13 times, most recently from 79dc06b to 5111f21 Compare August 7, 2023 13:42
skateman
skateman requested changes Aug 7, 2023
View reviewed changes
spec/api/v2/schemas/metadata.rb Outdated Show resolved Hide resolved
spec/api/v2/schemas/metadata.rb Outdated Show resolved Hide resolved
spec/api/v2/schemas/metadata.rb Outdated Show resolved Hide resolved
spec/api/v2/schemas/metadata.rb Outdated Show resolved Hide resolved
spec/swagger_helper.rb Outdated Show resolved Hide resolved
@romanblanco romanblanco force-pushed the RHICOMPL-3904-rswag-v2-init branch 2 times, most recently from bb043bf to 6d91433 Compare August 7, 2023 16:59
@romanblanco romanblanco marked this pull request as ready for review August 7, 2023 16:59
@romanblanco romanblanco requested a review from a team as a code owner August 7, 2023 16:59
skateman
skateman requested changes Aug 25, 2023
View reviewed changes
app/models/v2/security_guide.rb Outdated Show resolved Hide resolved
public/api/compliance/v2/openapi.json Outdated Show resolved Hide resolved
spec/api/v2/schemas/metadata.rb Outdated Show resolved Hide resolved
@romanblanco romanblanco force-pushed the RHICOMPL-3904-rswag-v2-init branch 3 times, most recently from 4c8cc1d to 8ce6900 Compare August 31, 2023 11:02
skateman
skateman requested changes Sep 1, 2023
View reviewed changes
spec/api/v2/schemas/types.rb Outdated Show resolved Hide resolved
spec/integration/security_guides_spec.rb Outdated Show resolved Hide resolved
spec/swagger_helper.rb Show resolved Hide resolved
xmicha82
xmicha82 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@xmicha82 xmicha82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romanblanco romanblanco force-pushed the RHICOMPL-3904-rswag-v2-init branch 2 times, most recently from 62a59fd to 178ed5e Compare September 14, 2023 07:58
@romanblanco romanblanco force-pushed the RHICOMPL-3904-rswag-v2-init branch 10 times, most recently from 71ed337 to 3b797de Compare September 14, 2023 14:26
skateman
skateman reviewed Sep 14, 2023
View reviewed changes
spec/swagger_helper.rb Outdated Show resolved Hide resolved
@romanblanco romanblanco force-pushed the RHICOMPL-3904-rswag-v2-init branch 3 times, most recently from 293c10b to ee4ccd8 Compare September 14, 2023 18:39
skateman
skateman approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@skateman skateman merged commit f421c70 into RedHatInsights:master Sep 22, 2023
8 checks passed
@romanblanco romanblanco deleted the RHICOMPL-3904-rswag-v2-init branch September 22, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrblaho petrblaho petrblaho left review comments

@RoamingNoMaD RoamingNoMaD RoamingNoMaD left review comments

@skateman skateman skateman approved these changes

@xmicha82 xmicha82 xmicha82 approved these changes

Assignees
No one assigned
Labels
APIv2 REST API v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@romanblanco @skateman @petrblaho @xmicha82 @RoamingNoMaD