Merge pull request #3 from yaacov/update-dockerfile

update-makefile
RedHat-Israel · Jan 8, 2024 · c1d3d2e · c1d3d2e
2 parents 9e1d1cf + 2b04bcf
commit c1d3d2e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -15,8 +15,8 @@ jobs:
             3.9
             3.12
 
-    - name: Install dependencies
-      run: pip install --no-cache-dir -r requirements.txt
+    - name: Install dev dependencies
+      run: pip install --no-cache-dir -r requirements-dev.txt
 
     - name: Lint
       run: make lint
@@ -25,4 +25,4 @@ jobs:
       run: make test
 
     - name: Run code quality test
-      run: code-quality
+      run: make code-quality
diff --git a/Makefile b/Makefile
@@ -37,12 +37,12 @@ build-image:
 
 run-image:
 	@echo "Running container image ..."
-	podman run --rm \
+	podman run --rm -it \
 		--network host \
-		-v ../../examples:/app/examples:z \
-		-it $(IMAGE_NAME) \
-		--port $(PORT) \
-		--driver $(DRIVER_PATH)
+		-v ./examples:/app/examples:z \
+		-e PORT=$(PORT) \
+		-e DRIVER=$(DRIVER_PATH) \
+		$(IMAGE_NAME)
 
 clean:
 	-rm -rf .coverage