Gc add on

[sluetze]

Description

added add-on role for garbagecollection

Checklist/ToDo's

• Added documentation?
• Added release note entry? ( docs/release-notes.md )
• Tested?

[rbo]

/ok-to-test

[skull-cicd]

💀 There was an error during pre-commit / linter:

[INFO] Initializing environment for https://github.com/ansible-community/ansible-lint.git.
[INFO] Initializing environment for https://github.com/ansible-community/ansible-lint.git:.[community,yamllint].
[INFO] Installing environment for https://github.com/ansible-community/ansible-lint.git.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Ansible-lint.............................................................Failed
- hook id: ansible-lint
- exit code: 2

[WARNING]: Ansible is being run in a world writable directory
(/workspace/source), ignoring it as an ansible.cfg source. For more information
see
https://docs.ansible.com/ansible/devel/reference_appendices/config.html#cfg-in-
world-writable-dir
[WARNING]: Ansible is being run in a world writable directory
(/workspace/source), ignoring it as an ansible.cfg source. For more information
see
https://docs.ansible.com/ansible/devel/reference_appendices/config.html#cfg-in-
world-writable-dir
WARNING  Loading custom .yamllint config file, this extends our internal yamllint config.
WARNING  Listing 4 violation(s) that are fatal
yaml: no new line character at the end of file (new-line-at-end-of-file)
ansible/add-on-roles/garbagecollection/defaults/main.yml:3

yaml: no new line character at the end of file (new-line-at-end-of-file)
ansible/add-on-roles/garbagecollection/meta/main.yml:20

yaml: no new line character at the end of file (new-line-at-end-of-file)
ansible/add-on-roles/garbagecollection/tasks/post-install.yml:18

yaml: trailing spaces (trailing-spaces)
ansible/roles/openshift-4-cluster/tasks/create.yml:140

You can skip specific rules or tags by adding them to your configuration file:
# .ansible-lint
warn_list:  # or 'skip_list' to silence them completely
  - yaml  # Violations reported by yamllint

Finished with 4 failure(s), 0 warning(s) on 172 files.

[sluetze]

fixed the lint errors. i obviously wasnt concentrated when building the branch and included some commits which are related to another PR. I close the other PR, since its quite small stuff.

so this also fixes #278

[skull-cicd]

💀 There was an error during pre-commit / linter:

[INFO] Initializing environment for https://github.com/ansible-community/ansible-lint.git.
[INFO] Initializing environment for https://github.com/ansible-community/ansible-lint.git:.[community,yamllint].
[INFO] Installing environment for https://github.com/ansible-community/ansible-lint.git.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Ansible-lint.............................................................Failed
- hook id: ansible-lint
- exit code: 2

[WARNING]: Ansible is being run in a world writable directory
(/workspace/source), ignoring it as an ansible.cfg source. For more information
see
https://docs.ansible.com/ansible/devel/reference_appendices/config.html#cfg-in-
world-writable-dir
[WARNING]: Ansible is being run in a world writable directory
(/workspace/source), ignoring it as an ansible.cfg source. For more information
see
https://docs.ansible.com/ansible/devel/reference_appendices/config.html#cfg-in-
world-writable-dir
WARNING  Loading custom .yamllint config file, this extends our internal yamllint config.
WARNING  Listing 2 violation(s) that are fatal
yaml: no new line character at the end of file (new-line-at-end-of-file)
ansible/add-on-roles/garbagecollection/meta/main.yml:21

yaml: trailing spaces (trailing-spaces)
ansible/add-on-roles/garbagecollection/meta/main.yml:21

You can skip specific rules or tags by adding them to your configuration file:
# .ansible-lint
warn_list:  # or 'skip_list' to silence them completely
  - yaml  # Violations reported by yamllint

Finished with 2 failure(s), 0 warning(s) on 172 files.

[rbo]

Please remove tags add-ons let's just use post-install and post-install-add-ons thanks.

[rbo]

/retest

[rbo]

LGTM

[rbo]

Thank you for your contribution.