Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skull counter not incrementing and add debug print for GI #65

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

CelestialKitsune
Copy link
Contributor

This fixes the counter, however I've encountered this bug while testing in OSH.
image
The text box says 1st, but the counter clearly says 2, and I had indeed collected 2.

Hypothesis: the save init probably sets it to -1 instead of 0?

Leaving it as a draft for now

@ThatHypedPerson
Copy link
Contributor

ThatHypedPerson commented Jan 1, 2025

The item text gets its' count from rando_has_item(GI_OCEAN_SKULL_TOKEN), however something seems to go wrong with the process.

In my testing, it looks like everything is incremented after the text is displayed, causing the counter to be off by 1.

There is also a bug that the intended Ocean Token count is doubled if the game is reset due to both the counter being set and the token item being sent and not ignored. I'm not sure if I can add my own changes to this PR, but adding another statement to play_main_hooks.c seems to fix this.

skulltula_token_hooks.c is also currently untouched so it only properly handles Swamp Tokens for now, so it would need to be looked into to handle Ocean Tokens.

@CelestialKitsune
Copy link
Contributor Author

skulltula_token_hooks.c is also currently untouched so it only properly handles Swamp Tokens for now, so it would need to be looked into to handle Ocean Tokens.

Feel free to open a PR towards my branch if you want to tackle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants