-
-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: ReVanced Manager Compose #1409
Draft
Axelen123
wants to merge
296
commits into
dev
Choose a base branch
from
compose-dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+17,810
−18,691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because androidx.work.Data sucks and causes our app to crash.
* Contributors page - https://github.com/revanced/revanced-manager-compose/issues/34 * feat: adding ContributorScreen as clickable icons like the website * feat: adding ContributorScreen - Made changes that were asked for in prev PR - Currently just waiting on a git merge to get ArrowButton in * feat: adding ContributorScreen - Made changes that were asked for in prev PR - ArrowButton is also in use * feat: adding ContributorScreen - Made changes that were asked for in prev PR - ArrowButton is also in use - Fixed other PR comment changes * Apply suggestions from code review * Remove unused string resources --------- Co-authored-by: Ax333l <[email protected]>
--------- Co-authored-by: Aunali321 <[email protected]>
This is needed to avoid ANRs because it takes a while if the Apk is 100+ MB.
There are 9 dependencies update, changelog of this commit are available below here. Android Gradle Plugin: 8.0.1 -> 8.0.2 Kotlin: 1.8.21 -> 1.8.22 Android Compose BOM: 2023.05.01 -> 2023.06.01 Room: 2.5.1 -> 2.5.2 ReVanced Patcher: 11.0.1 -> 11.0.4 APKsig: 8.2.0-alpha05 -> 8.2.0-alpha10 Koin (Android, workmanager): 3.4.0 -> 3.4.2 Koin (Androidx Compose): 3.4.4 -> 3.4.5 Ktor: 2.3.0 -> 2.3.1
"A what? 1.8.22 isn't compatible, but the version bump indicate that it's supposed to be bug fixes????"
* Better description for the repository license badge * Clicking on badges open you the relevant url
3 tasks
Co-authored-by: oSumAtrIX <[email protected]> Co-authored-by: Ax333l <[email protected]>
Co-authored-by: Benjamin Halko <[email protected]> Co-authored-by: Benjamin <[email protected]> Co-authored-by: Ushie <[email protected]> Co-authored-by: Ax333l <[email protected]>
oSumAtrIX
force-pushed
the
dev
branch
2 times, most recently
from
October 6, 2024 01:14
7f6666c
to
820cd72
Compare
Co-authored-by: Ushie <[email protected]>
🦀 integrations are gone! 🦀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1676
TODO
compose-dev
branch so it can be merged intodev