Add isometric screenshot feature. #122
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
er2off
reviewed
Apr 30, 2024
source/client/app/Minecraft.cpp
Outdated
Comment on lines
506
to
513
| // getOptions()->m_bAmbientOcclusion = !getOptions()->m_bAmbientOcclusion; | ||
| // Minecraft::useAmbientOcclusion = getOptions()->m_bAmbientOcclusion; | ||
| // m_pLevelRenderer->allChanged(); | ||
|
|
||
| if (m_pGameRenderer->m_bIsometric) | ||
| m_pGameRenderer->m_isomStage = 100000; | ||
| else | ||
| m_pGameRenderer->startIsometricRender(); |
There was a problem hiding this comment.
uhm... no ambient occlusion toggle? maybe remap to other button?
There was a problem hiding this comment.
This is temporary and will be replaced.
| @@ -680,7 +863,7 @@ void GameRenderer::render(float f) | |||
| debugText << "ReMinecraftPE " << m_pMinecraft->getVersionString(); | |||
| debugText << "\n" << m_shownFPS << " fps, " << m_shownChunkUpdates << " chunk updates"; | |||
|
|
|||
| if (m_pMinecraft->getOptions()->m_bDebugText) | |||
| if (m_pMinecraft->getOptions()->m_bDebugText && !m_pMinecraft->getOptions()->m_bDontRenderGui) | |||
There was a problem hiding this comment.
finally! actually it's not part of isometric renderer but anyway
There was a problem hiding this comment.
To be honest this condition is redundant, as if m_bDontRenderGui is true, there's an early return
er2off
reviewed
May 2, 2024
| @@ -641,8 +845,10 @@ void GameRenderer::render(float f) | |||
| renderLevel(f); | |||
| if (m_pMinecraft->getOptions()->m_bDontRenderGui) | |||
| { | |||
| if (!m_pMinecraft->m_pScreen) | |||
| if (!m_pMinecraft->m_pScreen) { | |||
There was a problem hiding this comment.
We definitely need to set up something like clang-format, code is using Microsoft-ish style but some code like this formatted incorrectly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an isometric screenshot feature to the game.
What is there more to do? The following: