Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check loadRemixDisabled #1145

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Check loadRemixDisabled #1145

merged 4 commits into from
Nov 27, 2024

Conversation

sra405
Copy link
Contributor

@sra405 sra405 commented Nov 27, 2024

Initial attempt at a fix for auto loading remixes when we explicitly don't want to to avoid editor projects remixing, loading the remix then causing a url changed based off the load rather than remix response

@sra405 sra405 temporarily deployed to previews/1145/merge November 27, 2024 11:12 — with GitHub Actions Inactive
@sra405 sra405 temporarily deployed to previews/1145/merge November 27, 2024 11:16 — with GitHub Actions Inactive
@sra405 sra405 temporarily deployed to previews/1145/merge November 27, 2024 11:17 — with GitHub Actions Inactive
Copy link
Contributor

@loiswells97 loiswells97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - it's kicking off about the linting though 😅

@sra405
Copy link
Contributor Author

sra405 commented Nov 27, 2024

Looks good - it's kicking off about the linting though 😅

haha hadn't spotted that!! Classic

Copy link
Contributor

@loiswells97 loiswells97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@sra405 sra405 merged commit 18e1e3d into main Nov 27, 2024
8 checks passed
@sra405 sra405 deleted the fix-auto-remix-loading branch November 27, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants