Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructs python outputs and adds file "run.py" #35

Merged
merged 9 commits into from
Jun 11, 2024

Conversation

DrPaulSharp
Copy link
Collaborator

No description provided.

@DrPaulSharp DrPaulSharp requested a review from StephenNneji June 10, 2024 14:27
RAT/inputs.py Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file does not contain any tests just fixtures, please rename the file to make it clear. Also I would prefer this data was stored in a pickle file then a script to regenerate and pickle the data was provided instead. otherwise this file would be a pain to update

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"conftest.py" is the name required for pytest discoverability of shared fixtures, see: https://docs.pytest.org/en/6.2.x/fixture.html#conftest-py-sharing-fixtures-across-multiple-files

@DrPaulSharp DrPaulSharp merged commit 558ad61 into RascalSoftware:main Jun 11, 2024
6 checks passed
@DrPaulSharp DrPaulSharp deleted the born_to_run branch June 11, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants