Adds terminal widget and ability to run RAT #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alexhroom
force-pushed
the
5-9-run-and-console
branch
2 times, most recently
from
89d6cdd to
76ac9ad
Compare
There was a problem hiding this comment.
This looks good and works very well. Please see other comments
I had another look at RasCAL-1 and realised it cleared the terminal before each run which felt less cluttered to me because after a few runs, I would get lost trying to scroll to the top of the current run. Maybe a toggle/setting to hide the history and show current run only might be useful, what do you think?
alexhroom
force-pushed
the
5-9-run-and-console
branch
from
2f8353b to
6e715e8
Compare
alexhroom
force-pushed
the
5-9-run-and-console
branch
from
6e715e8 to
9e8adfb
Compare
StephenNneji
reviewed
Oct 2, 2024
alexhroom
force-pushed
the
5-9-run-and-console
branch
from
9e8adfb to
50b6e45
Compare
alexhroom
force-pushed
the
5-9-run-and-console
branch
from
50b6e45 to
847007b
Compare
StephenNneji
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a terminal widget and the ability to run RAT within RasCAL-2.
Fixes #5 and #9.
Changes:
TerminalWidgetwhich displays logging data and event data for a RAT run (including GUI progress bar for DREAM)RATRunnerclass which runs RAT in a separateProcessand handles event and result dataMainWindowPresenterfor starting and interrupting a RAT run and handling the outcome, and connects these to the relevant buttons on the Controls widgetdemo.mp4