Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the startup widget and project dialog #18

Merged
merged 8 commits into from
Sep 3, 2024
Merged

Added the startup widget and project dialog #18

merged 8 commits into from
Sep 3, 2024

Conversation

RabiyaF
Copy link
Collaborator

@RabiyaF RabiyaF commented Aug 18, 2024 •
edited
Loading

Fixes #2
Fixes #3

startup_demo.mp4
  • Added ProjectDialog
  • Added StartUpWidget
  • Added tests

@RabiyaF RabiyaF marked this pull request as draft August 18, 2024 20:24
@RabiyaF RabiyaF self-assigned this Aug 19, 2024
@RabiyaF RabiyaF force-pushed the 2-add-startup-widget branch 2 times, most recently from 92353a9 to e10771d Compare August 21, 2024 23:08
@RabiyaF RabiyaF marked this pull request as ready for review August 21, 2024 23:12
@RabiyaF RabiyaF requested a review from StephenNneji August 22, 2024 10:28
@alexhroom alexhroom mentioned this pull request Aug 28, 2024
Merged
StephenNneji
StephenNneji reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@StephenNneji StephenNneji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The start-up dialog is looking good, please see comments

rascal2/dialogs/startup_dialog.py Outdated Show resolved Hide resolved
rascal2/dialogs/startup_dialog.py Outdated Show resolved Hide resolved
rascal2/dialogs/startup_dialog.py Outdated Show resolved Hide resolved
rascal2/dialogs/startup_dialog.py Outdated Show resolved Hide resolved
rascal2/dialogs/startup_dialog.py Outdated Show resolved Hide resolved
rascal2/dialogs/startup_dialog.py Outdated Show resolved Hide resolved
tests/test_dialogs.py Outdated Show resolved Hide resolved
rascal2/dialogs/startup_dialog.py Outdated Show resolved Hide resolved
alexhroom
alexhroom reviewed Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@alexhroom alexhroom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was just looking at this to figure out how to integrate the PRs i'm working on with it and had some comments, mainly documentation and some things to make it behave nicer with future functionality. all very neat and tidy code though! :)

rascal2/ui/view.py Outdated Show resolved Hide resolved
rascal2/dialogs/project_dialog.py Outdated Show resolved Hide resolved
rascal2/dialogs/project_dialog.py Outdated Show resolved Hide resolved
rascal2/dialogs/project_dialog.py Outdated Show resolved Hide resolved
@alexhroom alexhroom mentioned this pull request Aug 30, 2024
Merged
@RabiyaF
Copy link
Collaborator Author

RabiyaF commented Aug 30, 2024

Thanks for the comments Alex.

But please don't review my pull requests before they are marked ready for review again. It is a work in progress. Most of the changes you suggested would have to be updated based on Stephens comments. Those comments are still unresolved. Once it is ready, I don't mind how many people review it.

@alexhroom
Copy link
Collaborator

alexhroom commented Aug 30, 2024 •
edited
Loading

sorry! my comments didn't intersect the unresolved ones (edit: except in one place, whoops) so I thought it'd be fair game, especially since they were just documentation changes. won't do it again, thanks for the heads-up on your workflow :)

@RabiyaF RabiyaF changed the title Added the start up dialog class Added the startup widget and project dialog Sep 1, 2024
alexhroom
alexhroom reviewed Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@alexhroom alexhroom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! - a few comments mostly on internals

rascal2/dialogs/project_dialog.py Outdated Show resolved Hide resolved
rascal2/dialogs/project_dialog.py Outdated Show resolved Hide resolved
rascal2/ui/view.py Outdated Show resolved Hide resolved
rascal2/widgets/startup_widget.py Outdated Show resolved Hide resolved
rascal2/dialogs/project_dialog.py Show resolved Hide resolved
rascal2/dialogs/project_dialog.py Outdated Show resolved Hide resolved
rascal2/dialogs/project_dialog.py Outdated Show resolved Hide resolved
StephenNneji
StephenNneji reviewed Sep 2, 2024
View reviewed changes
rascal2/dialogs/project_dialog.py Outdated Show resolved Hide resolved
rascal2/dialogs/project_dialog.py Show resolved Hide resolved
rascal2/ui/view.py Outdated Show resolved Hide resolved
rascal2/dialogs/project_dialog.py Outdated Show resolved Hide resolved
rascal2/ui/view.py Outdated Show resolved Hide resolved
rascal2/dialogs/project_dialog.py Outdated Show resolved Hide resolved
tests/test_dialogs.py Outdated Show resolved Hide resolved
@RabiyaF RabiyaF force-pushed the 2-add-startup-widget branch from ad190b4 to 363314e Compare September 2, 2024 23:57
@RabiyaF RabiyaF force-pushed the 2-add-startup-widget branch from 363314e to 8ea0205 Compare September 3, 2024 00:01
This was referenced Sep 3, 2024
Closed
Closed
@RabiyaF @StephenNneji
refactored toggleView
8ff1f0a 
Co-authored-by: StephenNneji <[email protected]>
@RabiyaF RabiyaF requested a review from StephenNneji September 3, 2024 14:43
StephenNneji
StephenNneji approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@StephenNneji StephenNneji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sticking with it. Please see final comments

rascal2/dialogs/project_dialog.py Outdated Show resolved Hide resolved
rascal2/ui/presenter.py Show resolved Hide resolved
tests/test_dialogs.py Outdated Show resolved Hide resolved
@StephenNneji StephenNneji merged commit 998ff0a into RascalSoftware:main Sep 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexhroom alexhroom alexhroom left review comments

@StephenNneji StephenNneji StephenNneji approved these changes

Assignees

@RabiyaF RabiyaF

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create the start-up widgets Create new project Dialog
3 participants
@RabiyaF @alexhroom @StephenNneji