[ATO-1652] Add target to check if gRPC code is in sync with generated python code #1111
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radovanZRasa
force-pushed
the
ci/ATO-1652-check-for-proto-python-discrepancy
branch
2 times, most recently
from
661dade
to
68f755f
Compare
radovanZRasa
force-pushed
the
ci/ATO-1652-check-for-proto-python-discrepancy
branch
2 times, most recently
from
6d37786
to
fcdb1d3
Compare
radovanZRasa
force-pushed
the
ci/ATO-1652-check-for-proto-python-discrepancy
branch
from
fcdb1d3
to
8b8ce99
Compare
radovanZRasa
commented
Jun 19, 2024
| @@ -59,6 +59,9 @@ jobs: | |||
| - name: Install Dependencies 📦 | |||
| run: make install | |||
|
|
|||
| - name: Listing Dependencies 📦 | |||
There was a problem hiding this comment.
Added this to help with debugging.
radovanZRasa
commented
Jun 19, 2024
| @@ -20,6 +20,10 @@ install: | |||
| poetry run python -m pip install -U pip | |||
| poetry install | |||
|
|
|||
| install-dev: | |||
There was a problem hiding this comment.
Target to install runtime and dev dependencies.
sanchariGr
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Makefile target to check if gRPC
.protofiles and generated Python code are in sync.Target is part of existing
make lintwhich is already part of CI.Status (please check what you already did):
black(please check Readme for instructions)