Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement tracing in action server #1016

Merged
merged 8 commits into from
Aug 2, 2023
Merged

Implement tracing in action server #1016

merged 8 commits into from
Aug 2, 2023

Conversation

Tawakalt
Copy link
Contributor

@Tawakalt Tawakalt commented Jul 27, 2023 •
edited by vcidst
Loading

Proposed changes:

  • Fixes ATO-783

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation in the rasaHQ/rasa
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Tawakalt Tawakalt marked this pull request as draft July 27, 2023 13:07
@Tawakalt Tawakalt force-pushed the implement-tracing-in-action-server branch from debd34b to f043fe9 Compare July 27, 2023 13:19
@Tawakalt Tawakalt force-pushed the implement-tracing-in-action-server branch from cff3d6a to 38fc2b4 Compare July 27, 2023 14:46
@Tawakalt Tawakalt force-pushed the implement-tracing-in-action-server branch 2 times, most recently from 933637c to 7a8ae32 Compare July 28, 2023 08:26
@Tawakalt Tawakalt force-pushed the implement-tracing-in-action-server branch from 7a8ae32 to 8019db4 Compare July 28, 2023 08:43
@Tawakalt Tawakalt requested a review from vcidst July 28, 2023 09:12
@Tawakalt
Copy link
Contributor Author

Tawakalt commented Jul 28, 2023 •
edited
Loading

@vcidst

Asking for first round of review while I add tests 🙏🏾

Done!

@Tawakalt Tawakalt force-pushed the implement-tracing-in-action-server branch 4 times, most recently from f4a2301 to fc69051 Compare July 28, 2023 11:32
@Tawakalt Tawakalt force-pushed the implement-tracing-in-action-server branch from fc69051 to 4d0fc82 Compare July 28, 2023 11:38
@Tawakalt Tawakalt force-pushed the implement-tracing-in-action-server branch from 68f5290 to f56a665 Compare July 28, 2023 11:56
vcidst
vcidst reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@vcidst vcidst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really clean code and implementation 💯

We should add a section in the readme about what-is-tracing and how to add any additional spans, span attributes if someone wants to (say span inside custom actions or helper methods)

pyproject.toml Show resolved Hide resolved
tests/tracing/fixtures/otlp_endpoints.yml Show resolved Hide resolved
tests/tracing/instrumentation/test_tracing.py Outdated Show resolved Hide resolved
tests/tracing/test_config.py Outdated Show resolved Hide resolved
@Tawakalt Tawakalt marked this pull request as ready for review July 28, 2023 13:49
@Tawakalt
Copy link
Contributor Author

We should add a section in the readme about what-is-tracing and how to add any additional spans, span attributes if someone wants to (say span inside custom actions or helper methods)

I'd prefer that documentation to be a separate ticket so it's not blocking this.

@Tawakalt Tawakalt requested a review from vcidst July 31, 2023 13:52
vcidst
vcidst approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@vcidst vcidst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just added a small suggestion to expand on the changelog

changelog/1016.feature.md Outdated Show resolved Hide resolved
rasa_sdk/tracing/utils.py
Comment on lines +18 to +19
if "endpoints" in cmdline_arguments:
endpoints_file = cmdline_arguments.endpoints
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

@Tawakalt Tawakalt force-pushed the implement-tracing-in-action-server branch from 7134e08 to efa5270 Compare August 1, 2023 15:54
@Tawakalt Tawakalt merged commit 85782f3 into main Aug 2, 2023
13 checks passed
@Tawakalt Tawakalt deleted the implement-tracing-in-action-server branch August 2, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcidst vcidst vcidst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tawakalt @vcidst