Skip to content

Commit

Permalink
ENG-1235: Enable triggering release-tagging workflow manually on-dema…
Browse files Browse the repository at this point in the history
…nd also (#1142)

* ENG-1235: Enable triggering release-tagging workflow manually on-demand also, in case previous auto-run(s) had failed

* ENG-1235: Addressed PR feedback to update slack notification trigger condition, to not check for tag-build
  • Loading branch information
AsadHasan-Rasa authored Aug 29, 2024
1 parent 5d616cc commit cc95cc1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/release-artifacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,15 +146,15 @@ jobs:
echo "RASA_SDK_VERSION=${RASA_SDK_VERSION/refs\/tags\//}" >> $GITHUB_ENV
- name: Notify Slack 💬
if: env.IS_TAG_BUILD && success()
if: success()
env:
SLACK_WEBHOOK: ${{ secrets.SLACK_RELEASE_ASSISTANT_RELEASE_WEBHOOK }}
uses: Ilshidur/[email protected]
with:
args: "⚡ New *Rasa SDK* version ${{ env.RASA_SDK_VERSION }} has been released! Changelog: https://github.com/RasaHQ/rasa-sdk/blob/${{ env.RASA_SDK_VERSION }}/CHANGELOG.mdx"

- name: Notify Slack of Failure ⛔
if: env.IS_TAG_BUILD && failure()
if: failure()
env:
SLACK_WEBHOOK: ${{ secrets.SLACK_RELEASE_ASSISTANT_DEV_TRIBE_WEBHOOK }}
uses: Ilshidur/[email protected]
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/tag-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
- main
- '[0-9]+.[0-9]+.x'
types: [closed]
workflow_dispatch:

env:
COMMIT_EMAIL: [email protected]
Expand Down

0 comments on commit cc95cc1

Please sign in to comment.