Add defines for float math functions #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandyGaul
reviewed
Jun 19, 2024
include/cute_math.h
Outdated
| #include <math.h> | ||
| #define CF_SQRTF sqrtf |
There was a problem hiding this comment.
Would you be okay with doing this for each one?
#ifndef CF_SQRTF
#define CF_SQRTF sqrtf
#endifThat way we don't need CF_NO_DEFAULT_MATH_FUNCTIONS at all
There was a problem hiding this comment.
sure.
Though, my thought process was if there's a CF_NO_DEFAULT_MATH_FUNCTIONS, then I can avoid including math.h entirely
I couldn't think of why I'd want to override just one or two math functions, so I didn't copy to pattern from cute_c_runtime.h
There was a problem hiding this comment.
I see okay, feel free to leave it then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.