final csv/json data preview alpha changes for #30 feature release

RandomFractals · May 18, 2019 · 0a48506 · 0a48506
1 parent 427db31
commit 0a48506
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 8 deletions.
diff --git a/images/vega-viewer-data-preview.png b/images/vega-viewer-data-preview.png
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "vscode-vega-viewer",
   "displayName": "Vega Viewer",
   "description": "Vega Viewer",
-  "version": "4.6.0",
+  "version": "5.0.0",
   "publisher": "RandomFractalsInc",
   "author": "Taras Novak",
   "contributors": [

diff --git a/src/vega.preview.ts b/src/vega.preview.ts
@@ -25,7 +25,7 @@ export class VegaPreviewSerializer implements WebviewPanelSerializer {
 
   async deserializeWebviewPanel(webviewPanel: WebviewPanel, state: any) {
     const logger = new Logger('vega.preview.serializer:', LogLevel.Debug); // .Info for prod
-    logger.logMessage(LogLevel.Debug, 'deserializeWeviewPanel(): url:', state.uri.toString());
+    logger.logMessage(LogLevel.Info, 'deserializeWeviewPanel(): url:', state.uri.toString());
     previewManager.add(
       new VegaPreview(
         this.extensionPath, 
@@ -50,7 +50,7 @@ export class VegaPreview {
   private _title: string;
   private _html: string;
   private _panel: WebviewPanel;
-  private _logger = new Logger('vega.preview:', LogLevel.Debug); // .Info for prod
+  private _logger = new Logger('vega.preview:', LogLevel.Info); // change to .Debug for debug
 
   /**
    * Creates new Vega preview.

diff --git a/templates/data.preview.html b/templates/data.preview.html
@@ -50,9 +50,13 @@
         font-size: 11pt;
         text-align: center;
       }
-      perspective-viewer {
-        width: 100%;
-        height: 100%;
+      #data-viewer {
+        position: absolute;
+        top: 36px;
+        bottom: 0;
+        left: 0;
+        right: 0;
+        border: 1px solid #999;
       }
     </style>
   </head>
@@ -61,12 +65,12 @@
       <div style="float: right; width: 180px;">
         data:
         <select id="data-selector" onChange="changeData()">
-        </select> &nbsp;
+        </select>
       </div>
       <h3 id="title">loading...</h3>
     </div>
     <div id="message">Loading data preview...</div>
-    <perspective-viewer view="grid"></perspective-viewer>
+    <perspective-viewer id="data-viewer" view="grid"></perspective-viewer>
     <script type="text/javascript">
       let vscode, viewer, message, data, title, dataSelector, selectedData = '';
       // check web assembly support