Fix MCV resource retrieval error conversion #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there was an issue where the conversion of MCV retrieval errors was not handled properly, leading to unexpected behavior in certain cases. This commit fixes the issue by parsing the MCV condition message looking for errors formatted a certain way. Signed-off-by: Benamar Mekhissi <[email protected]>
BenamarMk
force-pushed
the
fix-get_mcv-returning-misleading-error
branch
from
57e0cc2
to
f5dffa5
Compare
ShyamsundarR
approved these changes
May 5, 2023
BenamarMk
changed the title
|
Ran a round of VR based e2e tests using drenv, works as expected. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was an issue where the conversion of MCV retrieval errors was not handled properly, leading to unexpected behavior in certain cases.
This PR fixes the issue by parsing the
MCV.Status.Conditions[0].Messagefield for known error strings, Specificallynot foundandthe server could not find the requested resourceerror messages. While this approach is effective for identifying errors in the short term, it is not a sustainable solution.As a next step, an issue should be opened against the ACM View Controller to fix and improve the MCV status,
potentially by adding the last error to the
MCV.Statusfield. This would allow for more comprehensive and accurateerror reporting, and reduce the need for temporary workarounds.
Fixes: bz:2138855 and bz:2170684
Multicloud-operators-foundationfor preserving original error inview_controllerresource retrievalissue: here