Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop OLED flip for TS80P #27

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Drop OLED flip for TS80P #27

merged 4 commits into from
Sep 25, 2024

Conversation

Ralim
Copy link
Owner

@Ralim Ralim commented Apr 9, 2024

fixes #23

@Ralim Ralim requested a review from discip April 9, 2024 08:28
@discip
Copy link
Collaborator

discip commented Apr 9, 2024

Not able to test as my ST-Link isn't detected anymore.

Will report back as soon as the TS80P is alive again.

@discip
Copy link
Collaborator

discip commented Jun 16, 2024

@Ralim
This is not going to fix the problem as this PR only affects the TS80.

I tried it with the corresponding line removed for the TS80P, but that only made the text readable for lefties.

The current issue is that all content shown on the OLED display is mirrored along the vertical center of the screen, so to read the text you need to read the letters from right to left, while each letter is reversed.
(Or you could hold the iron with the usb side to a mirror and read it in there.)

I think the issue is the removal of these lines that you deleted in commit 628fc98:

#ifdef OLED_FLIP
    0x80, 0xA1, /*Set Segment remap to backwards*/
#else
    0x80, 0xA0, /*Set Segment remap to normal*/
#endif

Just a guess though. 😊

@Ralim
Copy link
Owner Author

Ralim commented Jun 17, 2024

Hmm, those lines were pulled to the header and should be the same.
Will need to test this though

@discip
Copy link
Collaborator

discip commented Jun 19, 2024

@Ralim
Have you by any chance had time to look into this?

@discip
Copy link
Collaborator

discip commented Aug 20, 2024

@Ralim
Hope you have some time to sort this out.
Just so we are on the same page, that's what I'm seeing:

flipped_screen

thanks in advance

@discip
Copy link
Collaborator

discip commented Aug 23, 2024

@Ralim
Now it's in leftie mode. (readable but upside down) 🤣

@discip discip closed this Aug 24, 2024
@discip discip reopened this Aug 24, 2024
@discip
Copy link
Collaborator

discip commented Sep 17, 2024

@Ralim
ping 😊

@Ralim
Copy link
Owner Author

Ralim commented Sep 25, 2024

@discip
Pong 🤣
Works for me here

@discip
Copy link
Collaborator

discip commented Sep 25, 2024

Thank you so much! 👍

It finally works!

@discip discip enabled auto-merge (squash) September 25, 2024 20:05
@discip discip merged commit 69657e9 into mainline Sep 25, 2024
14 checks passed
@discip discip deleted the TS80P-flip branch September 25, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS80/P horizontally flipped bootloader screen
2 participants