Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tellable should respond to private messages #374

Open
treyharris opened this issue Jan 28, 2020 · 4 comments
Open

Tellable should respond to private messages #374

treyharris opened this issue Jan 28, 2020 · 4 comments
Labels
tellable Issues related to Tellable bot testneeded Issue is generally resolved but tests were not written yet

Comments

@treyharris
Copy link

Since you have to mention the nick if you want to .tell, if the user leaves themselves afk on the channel, you take the risk of setting off a sleepytime notification in simply mentioning them in the .tell. So I’d suggest either:

  1. A change to irc-privmsg-me so that you can /MSG tellable6 tell nick@channel; or
  2. A change to normalize-weirdly to strip out tildes (~), which are not allowed in nicks. Then you can do .tell trey~harris or some-such to keep the channel from ringing the user.

I’m capable of submitting a PR for either if you want to just select one. Thanks!

@treyharris treyharris added the tellable Issues related to Tellable bot label Jan 28, 2020
@treyharris
Copy link
Author

Btw, looking at normalize-weirdly: underscores are valid nick characters, so I think this may cause bad behavior for users with underscore-containing nicks?

A valid PCRE for valid nicks not including Unicode extensions is:

/\A[a-z_\-\[\]\\^{}|`][a-z0-9_\-\[\]\\^{}|`]*\z/i

And the Unicode extensions (which should be pretty easy to add in Raku) are shown here.

@treyharris
Copy link
Author

Actually, that last comment doesn’t belong here. I’ll promote it to its own issue.

@AlexDaniel
Copy link
Member

Yes, tellable6 should start responding to private messages. It's blocked by default here because there are all kinds of damage you can do via private messages (in case of tellable it can be something stupid like sending a message to each user on the channel resulting in annoying bot spam). Better safe than sorry, but in case of tellable6 we should probably be a bit more permissive.

As for normalize-weirdly, it's designed to be that way. For example, it's so that when you send a message to Coke (which users do often) it gets received by [Coke] and vice versa. Yes, these are distinct nicknames and of course different users can have them at the same time, but in practice that never happens on our channels. This function was designed by analyzing messages that were never delivered by the previous bot, and it works like a treat. Technically it's wrong, but reality is that users are constantly changing their nicknames and people don't remember all the intricate details of every nickname.

@AlexDaniel AlexDaniel changed the title tellable: don’t require open-channel literal mention Tellable should respond to private messages Jan 28, 2020
AlexDaniel added a commit that referenced this issue Mar 27, 2020
Currently only for linkable6, notable6, releasable6 and one another
upcoming bot.

Addresses #374 (but without tests). #350 is related.
@AlexDaniel AlexDaniel added the testneeded Issue is generally resolved but tests were not written yet label Mar 27, 2020
@AlexDaniel
Copy link
Member

I'm pretty sure this is now working (some bots will start responding to private messages after they're updated). Tests needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tellable Issues related to Tellable bot testneeded Issue is generally resolved but tests were not written yet
Projects
None yet
Development

No branches or pull requests

2 participants