Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nick recognition and normalization is wrong #375

Closed
treyharris opened this issue Jan 28, 2020 · 1 comment
Closed

nick recognition and normalization is wrong #375

treyharris opened this issue Jan 28, 2020 · 1 comment
Labels
tellable Issues related to Tellable bot

Comments

@treyharris
Copy link

Looking at normalize-weirdly: underscores are valid nick characters, so I think this may cause bad behavior for users with underscore-containing nicks? The comments mention that the substitutions are based on actual failed messages, but I think perhaps the diagnostic of underscores is wrong? (Also, many IRC clients deal with a nick being already taken by prepending or appending underscore(s), so perhaps that’s where you saw nicks with underscores being “wrong”?)

A valid PCRE for valid nicks not including Unicode extensions is:

/\A[a-z_\-\[\]\\^{}|`][a-z0-9_\-\[\]\\^{}|`]*\z/i

And the Unicode extensions (which should be pretty easy to add in Raku) are shown here.

@treyharris treyharris added the all bots Issues affecting all (or most) of the bots label Jan 28, 2020
@AlexDaniel AlexDaniel added tellable Issues related to Tellable bot and removed all bots Issues affecting all (or most) of the bots labels Jan 28, 2020
@AlexDaniel
Copy link
Member

Answered here: #374 (comment)
TL;DR it's meant to be that way and there's no need to change it unless we stumble upon a real life issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tellable Issues related to Tellable bot
Projects
None yet
Development

No branches or pull requests

2 participants