Implement distance module #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorporated a distance detector module in the main codebase. The xe121 example has been expanded and updated to accommodate this module, including necessary modifications for data handling and result processing within the example. All dependencies and relevant functions have likewise been updated to ensure compatibility.
The RadarState trait has been made public and added to generic constraints in relevant structures and implementations. Additionally, an unsafe function to get a mutable reference to the sensor was added for completeness. This is part of a broader effort to refine our radar capabilities and ensure robust error handling.
The Radar, Sensor, and RadarDistanceDetector structs have been extended to incorporate pin outputs and delays, using the embedded_hal and embedded_hal_async libraries. The changes also include edit all related function signatures and calls. This addition provides support for hardware control, enabling and disabling the radar sensor when required.
noahbliss
reviewed
Feb 29, 2024
noahbliss
reviewed
Feb 29, 2024
noahbliss
approved these changes
Feb 29, 2024
noahbliss
pushed a commit
that referenced
this pull request
Mar 9, 2024
* Adjust code for distance measurement capability Incorporated a distance detector module in the main codebase. The xe121 example has been expanded and updated to accommodate this module, including necessary modifications for data handling and result processing within the example. All dependencies and relevant functions have likewise been updated to ensure compatibility. * Make RadarState trait public and add to generic constraints The RadarState trait has been made public and added to generic constraints in relevant structures and implementations. Additionally, an unsafe function to get a mutable reference to the sensor was added for completeness. This is part of a broader effort to refine our radar capabilities and ensure robust error handling. * Refactor Radar and Sensor structs to support OutputPin and Delay The Radar, Sensor, and RadarDistanceDetector structs have been extended to incorporate pin outputs and delays, using the embedded_hal and embedded_hal_async libraries. The changes also include edit all related function signatures and calls. This addition provides support for hardware control, enabling and disabling the radar sensor when required. * Update Radar initialization and remove unnecessary pin control * Adjust threshold sensitivity in Radar config * Refactor main function and improve radar calibration * remove unused configs * Refactor DistanceSizes struct to results module * Update build optimization settings and clean up main.rs code * Adjust variable initialization and buffer sizes * Add type alias for result transitions in radar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.