-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
^ uvh5 addition #1511
Merged
kartographer
merged 5 commits into
RadioAstronomySoftwareGroup:main
from
MydonSolutions:uvh5_add
Dec 27, 2024
+24
−1
Merged
^ uvh5 addition #1511
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3883986
+ tests uvh5 addition
radonnachie 8dfe78a
+ tests uvh5 addition
radonnachie a924ab6
+ test uvh5 addition minimised ATA uvh5
radonnachie 6072930
^ uvdata _add get('info_source', None)
radonnachie 2601df0
*= PR requests, + CHANGELOG
radonnachie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file added
BIN
+273 KB
src/pyuvdata/data/ata.LoA.C0352.uvh5_60647_62965_9760406_3c286_0001.uvh5
Binary file not shown.
Binary file added
BIN
+273 KB
src/pyuvdata/data/ata.LoA.C0544.uvh5_60647_62965_9760406_3c286_0001.uvh5
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change this to:
self.phase_center_catalog[cat_id]["info_source"] = cat_entry.get("info_source")
Realizing this is pretty minor, although the plan for the phase dict is to become an actual object, where these will become optional attributes (which always exist as attributes on the object, but are filled in w/ None when not set), and this will basically make the code easier to migrate.