Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MWA Efield beam sign #1510

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Fix MWA Efield beam sign #1510

merged 3 commits into from
Jan 7, 2025

Conversation

bhazelton
Copy link
Member

@bhazelton bhazelton commented Dec 12, 2024

Description

We recently came up with a better way to check E-field beam signs. This led me to realize we had a sign flip in the azimuthally aligned response of the MWA beam. I tracked this down as a clear mistake in translating from the mwa_pb repo so I fixed it and added our new test (which fails on main).

I also realized that there was an error in the beam plots in our tutorials sourced by an unexpected (at least to me) default in imshow: the (0,0) element of the image is placed in the upper left rather than the lower left (which was my expectation). This is fixable via the origin keyword, so I set that for all the imshow plots in the tutorials and also improved the labelling of the beam plots to clearly indicate where East and North are.

I also snuck in a couple beam-related docstring fixes I noticed recently.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

Bug fix checklist:

  • My fix includes a new test that breaks as a result of the bug (if possible).
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

Documentation change checklist:

  • Any updated docstrings use the numpy docstring format.
  • If this is a significant change to the readme or other docs, I have checked that they are rendered properly on ReadTheDocs. (you may need help to get this branch to build on RTD, just ask!)

@bhazelton bhazelton added bug beams docs documentation labels Dec 12, 2024
@bhazelton bhazelton requested a review from jpober December 12, 2024 20:29
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (ed71586) to head (d06c6fc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1510   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          63       63           
  Lines       21849    21849           
=======================================
  Hits        21834    21834           
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bhazelton bhazelton force-pushed the fix_mwa_beam_orientation branch from 7ccc573 to e7491e0 Compare December 18, 2024 00:14
jpober
jpober previously approved these changes Jan 1, 2025
Copy link
Member

@jpober jpober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jpober
Copy link
Member

jpober commented Jan 1, 2025

Uh-oh, looks like I took too long and there are now conflicts in the changelog... If you can fix, I'll approve (quickly).

@jpober
Copy link
Member

jpober commented Jan 7, 2025

I assume failing on hera_cal shouldn't block a merge?

@bhazelton bhazelton merged commit bca6cf0 into main Jan 7, 2025
52 of 54 checks passed
@bhazelton bhazelton deleted the fix_mwa_beam_orientation branch January 7, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beams bug docs documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants