-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bls 3tuple #1507
Fix bls 3tuple #1507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2
.
Benchmark suite | Current: dab9ed7 | Previous: 72dd3bc | Ratio |
---|---|---|---|
tests/uvdata/test_mwa_corr_fits.py::test_read_mwa |
3.9132754759465858 iter/sec (stddev: 0.035221061015886734 ) |
7.997555508312163 iter/sec (stddev: 0.031847779135263966 ) |
2.04 |
tests/uvdata/test_mwa_corr_fits.py::test_read_mwax |
3.394458930320797 iter/sec (stddev: 0.10118858356508509 ) |
7.004348042731254 iter/sec (stddev: 0.013840146951652157 ) |
2.06 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1507 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 63 63
Lines 21834 21834
=======================================
Hits 21819 21819
Misses 15 15 ☔ View full report in Codecov by Sentry. |
Yes, I can verify that the code in #1505 produces the expected output now:
|
Description
Fixes a bug in selecting on UVData objects where if you used
bls=
with a list of 3-tuples where there is more than one polarization present, it would only select the last one.Motivation and Context
Fixes #1505
Types of changes
Checklist:
Bug fix checklist: