Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in the phase center info for FHD calibrations #1431

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

bhazelton
Copy link
Member

Description

Add code to set the phase_center_catalog and related attributes for FHD calibration solutions

Motivation and Context

Support for phase center info was added to UVCal in #1391, this PR adds the code to fill it in for FHD calibrations.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

New feature checklist:

  • I have added or updated the docstrings associated with my feature using the numpy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate).
  • I have added tests to cover my new feature.
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

@bhazelton bhazelton requested a review from kartographer April 18, 2024 22:12
@bhazelton bhazelton changed the base branch from main to prep_v3.0 April 18, 2024 22:13
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (eb3e8b8) to head (6dab0be).

Additional details and impacted files
@@            Coverage Diff             @@
##           prep_v3.0    #1431   +/-   ##
==========================================
  Coverage      99.92%   99.92%           
==========================================
  Files             41       41           
  Lines          22399    22406    +7     
==========================================
+ Hits           22383    22390    +7     
  Misses            16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kartographer kartographer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, also -- does this need a CHANGELOG update?

pyuvdata/uvcal/fhd_cal.py Show resolved Hide resolved
@bhazelton
Copy link
Member Author

I didn't add a changelog entry because I wasn't sure if it was needed -- there's no entry e.g. about calh5 supporting phase centers. But I can add one if you think I should.

@kartographer
Copy link
Contributor

I didn't add a changelog entry because I wasn't sure if it was needed -- there's no entry e.g. about calh5 supporting phase centers. But I can add one if you think I should.

That's fair -- I didn't think to add it specifically for CalH5 since it was a new feature, but since this is all getting pulled into the v3 branch (and to some degree, this is effectively "cleaning up" a piece that was missed in #1391), it's probably fine to bundle it under the existing changes.

@kartographer kartographer merged commit b54fce4 into prep_v3.0 Apr 18, 2024
41 of 44 checks passed
@kartographer kartographer deleted the add_fhdcal_phase_center branch April 18, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants