Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feko read #1328

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Add feko read #1328

wants to merge 16 commits into from

Conversation

nmahesh1412
Copy link

Description

added a feko_beam.py to read in feko .ffe files

Motivation and Context

adds the capability of reading in aFEKO simulation file

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

Bug fix checklist:

  • My fix includes a new test that breaks as a result of the bug (if possible).
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

New feature checklist:

  • I have added or updated the docstrings associated with my feature using the numpy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate).
  • I have added tests to cover my new feature.
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

Breaking change checklist:

  • I have updated the docstrings associated with my change using the numpy docstring format.
  • I have updated the tutorial to reflect my changes (if appropriate).
  • My change includes backwards compatibility and deprecation warnings (if possible).
  • I have added tests to cover my changes.
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

Documentation change checklist:

  • Any updated docstrings use the numpy docstring format.
  • If this is a significant change to the readme or other docs, I have checked that they are rendered properly on ReadTheDocs. (you may need help to get this branch to build on RTD, just ask!)

Version change checklist:

  • I have updated the CHANGELOG to put all the unreleased changes under the new version (leaving the unreleased section empty).
  • I have noted any dependency changes since the last version and will update the conda package build accordingly.

Build or continuous integration change checklist:

  • If required or optional dependencies have changed (including version numbers), I have updated the readme to reflect this.
  • If this is a new CI setup, I have added the associated badge to the readme and to references/make_index.py (if appropriate).

@nmahesh1412 nmahesh1412 requested a review from bhazelton August 15, 2023 19:33
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Attention: Patch coverage is 0.72727% with 273 lines in your changes missing coverage. Please review.

Project coverage is 98.66%. Comparing base (8f5a7db) to head (2638c31).

Files with missing lines Patch % Lines
src/pyuvdata/uvbeam/feko_beam.py 0.00% 143 Missing ⚠️
src/pyuvdata/uvbeam/uvbeam.py 1.51% 130 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1328      +/-   ##
==========================================
- Coverage   99.92%   98.66%   -1.27%     
==========================================
  Files          61       62       +1     
  Lines       21337    21612     +275     
==========================================
+ Hits        21322    21324       +2     
- Misses         15      288     +273     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 2638c31 Previous: 72dd3bc Ratio
tests/utils/test_bls.py::test_bls_to_ant[min=65536-len=100000] 1249.5568377300874 iter/sec (stddev: 0.0003251982305909074) 2697.029604108284 iter/sec (stddev: 0.00006945868233318298) 2.16
tests/utils/test_bls.py::test_bls_to_ant[min=4259840-len=100000] 1320.5759675732322 iter/sec (stddev: 0.00021325959314016785) 2842.225436345786 iter/sec (stddev: 0.00005047587926328867) 2.15

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants