-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code that raises new numpy deprecation warnings #1308
Conversation
012197c
to
aacc3a5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1308 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 36 36
Lines 20064 20091 +27
=======================================
+ Hits 20048 20075 +27
Misses 16 16
Continue to review full report in Codecov by Sentry.
|
Also improve `check_warnings` to give the file and line number where warnings occur to help with debugging.
aacc3a5
to
366d5f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me. I think my only question is why are we adding a lot of [0]
indices in places? Did we used to have length 1 dimensions that we are collapsing?
Yes. Numpy now complains about converting single element arrays to scalars: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one small typo
Description
Changes:
check_warnings
to give the file and line number where warnings occur to help with debugging.branch=True
for coverage (see Check for coverage on all branches #1309). So I added some tests to cover all the branches.Motivation and Context
Fix CI errors due to new numpy deprecation warnings.
Types of changes
Checklist:
Bug fix checklist: