Skip to content

Commit

Permalink
One more set of updates to address reviewer comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
kartographer authored and bhazelton committed Apr 18, 2024
1 parent d965272 commit eb3e8b8
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 10 deletions.
10 changes: 4 additions & 6 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,19 +50,17 @@ times for those solutions.
- Updated minimum optional dependency versions: astropy-healpix>=1.0.2

### Fixed
- Fixed a bug in `UVBase` where `allowed_failures` was being ignored if a parameter had
`required=True` set.
- Fixed a bug where selection and addition/concat methods did not operate correctly on
flex-spw `UVCal` objects where `Nspws>1`.
- Fixed a bug writing UVData objects to UVFITS formats with extra phase center catalog
entries resulted in an error on read.
- Fixed a bug where calling `UVData._set_app_coords_helper` with extra phase center
catalog entries resulted in an error.
- Bug in which `correct_cable_len` defaulted to `None` instead of `True`
for `read_mwa_corr_fits`.

### Fixed
- Fixed a bug in `UVBase` where `allowed_failures` was being ignored if a parameter had
`required=True` set.
- Fixed a bug where selection and addition/concat methods did not operate correctly on
flex-spw `UVCal` objects where `Nspws>1`.

## [2.4.3] - 2024-3-25

### Added
Expand Down
2 changes: 1 addition & 1 deletion pyuvdata/uvcal/calfits.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def write_calfits(
warnings.warn(
"The calfits format does not support recording optional phase center, "
"scan number, or time-varying reference antenna information, and "
"these information will be included in the written file."
"these information will not be included in the written file."
)

if self.Nspws > 1:
Expand Down
7 changes: 4 additions & 3 deletions pyuvdata/uvdata/tests/test_ms.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from ... import tests as uvtest
from ... import utils as uvutils
from ...data import DATA_PATH
from ...tests.test_utils import frame_selenoid
from ..uvdata import _future_array_shapes_warning

pytest.importorskip("casacore")
Expand Down Expand Up @@ -115,8 +116,8 @@ def test_cotter_ms():

@pytest.mark.filterwarnings("ignore:ITRF coordinate frame detected,")
@pytest.mark.filterwarnings("ignore:The uvw_array does not match the expected values")
@pytest.mark.parametrize("telescope_frame", ["itrs", "mcmf"])
def test_read_nrao_loopback(tmp_path, nrao_uv, telescope_frame):
@pytest.mark.parametrize(["telescope_frame", "selenoid"], frame_selenoid)
def test_read_nrao_loopback(tmp_path, nrao_uv, telescope_frame, selenoid):
"""Test reading in a CASA tutorial ms file and looping it through write_ms."""
uvobj = nrao_uv

Expand All @@ -125,7 +126,7 @@ def test_read_nrao_loopback(tmp_path, nrao_uv, telescope_frame):
enu_antpos, _ = uvobj.get_ENU_antpos()
latitude, longitude, altitude = uvobj.telescope_location_lat_lon_alt
uvobj._telescope_location.frame = "mcmf"
uvobj._telescope_location.ellipsoid = "SPHERE"
uvobj._telescope_location.ellipsoid = selenoid
uvobj.telescope_location_lat_lon_alt = (latitude, longitude, altitude)
new_full_antpos = uvutils.ECEF_from_ENU(
enu=enu_antpos,
Expand Down

0 comments on commit eb3e8b8

Please sign in to comment.