fix bug with telescope frame in uvdata._set_app_coords_helper

RadioAstronomySoftwareGroup · Mar 19, 2024 · 63c8373 · 63c8373
1 parent ed5393d
commit 63c8373
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/pyuvdata/uvdata/tests/test_ms.py b/pyuvdata/uvdata/tests/test_ms.py
@@ -136,6 +136,8 @@ def test_read_nrao_loopback(tmp_path, nrao_uv, telescope_frame):
         )
         uvobj.antenna_positions = new_full_antpos - uvobj.telescope_location
         uvobj.set_lsts_from_time_array()
+        uvobj.set_uvws_from_antenna_positions()
+        uvobj._set_app_coords_helper()
         uvobj.check()
 
     expected_extra_keywords = ["DATA_COL", "observer"]

diff --git a/pyuvdata/uvdata/tests/test_uvfits.py b/pyuvdata/uvdata/tests/test_uvfits.py
@@ -562,6 +562,8 @@ def test_readwriteread(tmp_path, casa_uvfits, future_shapes, telescope_frame, se
         )
         uv_in.antenna_positions = new_full_antpos - uv_in.telescope_location
         uv_in.set_lsts_from_time_array()
+        uv_in.set_uvws_from_antenna_positions()
+        uv_in._set_app_coords_helper()
         uv_in.check()
 
     uv_out = UVData()

diff --git a/pyuvdata/uvdata/uvdata.py b/pyuvdata/uvdata/uvdata.py
@@ -2509,6 +2509,8 @@ def _set_app_coords_helper(self, pa_only=False):
                     time_array=self.time_array[select_mask],
                     lst_array=self.lst_array[select_mask],
                     telescope_loc=self.telescope_location_lat_lon_alt,
+                    telescope_frame=self._telescope_location.frame,
+                    lunar_ellipsoid=self._telescope_location.lunar_ellipsoid,
                     coord_type=cat_type,
                 )
 
@@ -2524,12 +2526,14 @@ def _set_app_coords_helper(self, pa_only=False):
             epoch = temp_dict.get("cat_epoch")
             if not frame == "altaz":
                 frame_pa[select_mask] = uvutils.calc_frame_pos_angle(
-                    self.time_array[select_mask],
-                    app_ra[select_mask],
-                    app_dec[select_mask],
-                    self.telescope_location_lat_lon_alt,
-                    frame,
+                    time_array=self.time_array[select_mask],
+                    app_ra=app_ra[select_mask],
+                    app_dec=app_dec[select_mask],
+                    telescope_loc=self.telescope_location_lat_lon_alt,
+                    ref_frame=frame,
                     ref_epoch=epoch,
+                    telescope_frame=self._telescope_location.frame,
+                    lunar_ellipsoid=self._telescope_location.lunar_ellipsoid,
                 )
         self.phase_center_app_ra = app_ra
         self.phase_center_app_dec = app_dec