Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support for lcov/gcov with Ninja #30

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

giacomini
Copy link

@giacomini giacomini commented Jun 25, 2020

This is an attempt to better integrate the Ninja build system (issue #29, but also #6).

It is just meant for discussion, for there are still a few things to sort out, e.g. the target versions of CMake, Ninja, gcc, ... It's a bit of a mess.

Whatever the response, it would be nice to have a github action that runs tests for at least some combinations of the above.

Test the combinations (ninja,make) x (gcov,lcov)
If run from the *current* binary dir, gcov gives errors such as:
Cannot open source file ../src/libfoo/foo.c
The gcov files are all created in the same dir, but the -p option
should guarantee there are no name clashes
This seems the only way to make all the ninja/make combinations happy.
If this is really the case, some cleanup is needed.
External code should be excluded through LCOV_REMOVE_PATTERNS.
@codecov-commenter
Copy link

Codecov Report

Merging #30 (115a51d) into master (06a61fc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         4    -1     
  Lines           20        17    -3     
=========================================
- Hits            20        17    -3     
Impacted Files Coverage Δ
src/fortran/hello.f

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06a61fc...115a51d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants