Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CmdFlush_NoConfirm option to disable flush prompt #340

Closed
wants to merge 1 commit into from

Conversation

wulffern
Copy link

@wulffern wulffern commented Oct 9, 2024

In commands/CmdFI.c.

To ignore prompt

set CmdFlush_NoConfirm 1

To enable prompt again

unset CmdFlush_NoConfirm 

Copy link
Owner

@RTimothyEdwards RTimothyEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks conventions. I would rather see it implemented as command option flush -noprompt which is the convention used for the quit command as well. That will require changing the argument parsing to use Lookup() rather than the simple string compare (which also, mea culpa, breaks convention)

@wulffern
Copy link
Author

wulffern commented Oct 9, 2024

Sure thing, I'll give it a crack. To be continued.

@dlmiles
Copy link
Contributor

dlmiles commented Oct 9, 2024

issue #341 link issue

@wulffern
Copy link
Author

I'm closing this PR as it's fixed by PR #341

@wulffern wulffern closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants