-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:watchdog redefinition error #9588
base: master
Are you sure you want to change the base?
Conversation
为什么要重新对成员名定义? |
drv_wtd.h文件和dev_watchdog.h文件中内容重定义,编译报错,仅修改了结构体名称rt_watchdog_ops,rt_watchdog_device和结构体成员const struct rt_watchdog_ops *ops以及其他定义,修改后可以正常编译并启动开发板 |
那是不是直接引用dev_watchdog.h的内容就好了 |
dev_watchdog.h中可以引用的结构体不满足使用要求,所以上一个写drv_wtd.h的程序员定义了一个新的结构体,但是和dev_watchdog.h文件有部分结构体名重复了,改了drv_wtd.h中结构体名称解决了重定义问题 |
我看了下您这边提交的代码,发现和dev_watchdog.h中的内容几乎完全一致啊,没明白那块有不满足需求的,可以指出来看下
|
好像就是因为一样了,重复定义了。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
修复watchdog重定义err
你的解决方案是什么 (what is your solution)
改imx6ull-smart目录下wtd.h文件的结构体及成员名定义名称
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up