feat(worker/activitypub): implement mastodon worker to transform AP objects #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith 'Create' type (transform to activities in SocialPost and Social Comments)
…reate','Announce', 'Like') with test cases
FrankLi123
force-pushed
the
feat/integrate-activitypub-mastodon-worker
branch
from
e496004
to
53f97b9
Compare
FrankLi123
changed the title
brucexc
reviewed
Jul 30, 2024
config/config_test.go
Outdated
| @@ -33,6 +34,10 @@ endpoints: | |||
| url: https://rpc.ankr.com/eth | |||
| http_headers: | |||
| user-agent: rss3-node | |||
| mastodon: | |||
| url: https://30.10.000.00:9092/ | |||
There was a problem hiding this comment.
Suggested change
| url: https://30.10.000.00:9092/ | |
| The endpoint should be defined in the configuration file rather than hardcoding them. Sensitive information like this should not appear in the code, as it poses a security risk. |
There was a problem hiding this comment.
The url is a mock url used for the config test. Changed its value to https://0.0.0.0:9092/ for better view.
brucexc
reviewed
Jul 30, 2024
| case "Create": | ||
| err := w.handleActivityPubCreate(ctx, activityPubTask.Message, activity) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("error occured in handleActivityPubCreate") |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("error occured in handleActivityPubCreate") | |
| wrap the specific error | |
| Consider changing to: | |
| return nil, fmt.Errorf("error occurred in handleActivityPubCreate: %w", err) |
There was a problem hiding this comment.
and typo occured -> occcurred
brucexc
reviewed
Jul 30, 2024
| return nil, fmt.Errorf("error occurred in handleActivityPubLike: %w", err) | ||
| } | ||
| default: | ||
| zap.L().Debug("unsupported type", zap.String("type", activityPubTask.Message.Type)) |
There was a problem hiding this comment.
Suggested change
| zap.L().Debug("unsupported type", zap.String("type", activityPubTask.Message.Type)) | |
| using Info level instead of Debug |
brucexc
reviewed
Jul 30, 2024
| if err != nil { | ||
| return nil, fmt.Errorf("error occured in handleActivityPubCreate") | ||
| } | ||
| case "Announce": |
There was a problem hiding this comment.
Suggested change
| case "Announce": | |
| using an enumeration is better. |
There was a problem hiding this comment.
defined message types in the mastodon provider type file, and used the enumeration here
brucexc
reviewed
Jul 30, 2024
internal/engine/worker/federated/activitypub/mastodon/worker.go
Outdated
Show resolved
Hide resolved
brucexc
reviewed
Jul 30, 2024
|
|
||
| // Check if the Note is a reply to another post | ||
| // If true, then make it an activity SocialComment object | ||
| if parentID, ok := noteObject["inReplyTo"].(string); ok { |
There was a problem hiding this comment.
Suggested change
| if parentID, ok := noteObject["inReplyTo"].(string); ok { | |
| using constants for magic strings like "Note", "inReplyTo" |
brucexc
reviewed
Jul 30, 2024
internal/engine/worker/federated/activitypub/mastodon/worker.go
Outdated
Show resolved
Hide resolved
brucexc
reviewed
Jul 30, 2024
internal/node/indexer/server.go
Outdated
| case network.ActivityPubSource: | ||
| instance.monitorClient, err = monitor.NewActivityPubClient(config.EndpointID, config.Parameters) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("new arweave monitorClient: %w", err) |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("new arweave monitorClient: %w", err) | |
| incorrect error info |
…data-source' branch
FrankLi123
merged commit 749225c
into
feat/integrate-activitypub-mastodon-data-source
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Does this PR introduce a breaking change?
Other information