Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in roctxRangePushA #75

Open
wants to merge 49 commits into
base: amd-master
Choose a base branch
from
Open

Fix memory leak in roctxRangePushA #75

wants to merge 49 commits into from

Conversation

MrBurmark
Copy link

Do not strdup message when pushing to stack of std::strings.
Use emplace to avoid unnecessary std::string moves/copies.

Evgeny and others added 30 commits September 6, 2020 01:07
optimized tool stats;
6fffa50 
Change-Id: I1baab986d36207b87f6f9ad5e0a45a9cffbea0c8
flush-rate option fixed;
db1ccb0 
Change-Id: I50473f8008672772dd4aaf37cbc64472cb50b4a3
Format ostream ops;
dae98a3 
Change-Id: I33d01cde41d9a762a8a955a1faccfdef02d8c0ac
@rkebichi @parepate
Fix for trace checker
b730da0 
Change-Id: Ib8a0df7b7bb0da2e68b5b4d99ce8025de169f317
(cherry picked from commit 29da9a7)
@parepate
codeobj tracing prof protocol
4c2b6cb 
Change-Id: Ib49c8ee034fb7481b21f950490e10b350f2a1b79
(cherry picked from commit 6567c48)
@parepate
gen_ostream_ops.py fix - ostream operators as inline static
35bc1e9 
Change-Id: I9688236b06dd167960662b8eecf1a07c93b43fff
(cherry picked from commit c9ed0f0)
build normalizing - generating under build directory
5bf3efa 
Change-Id: Id9203aec7800024bd749059a415fb29b8051005a
testing using v3 object
401c48b 
Change-Id: Ifca31d632726ab83f4c672b46cd9b97f817e757d
HCC_HOME env cleanup
96ea2d6 
Change-Id: I2b00e5d310e6349fc52d5df60aae85f4c06adebe
@parepate
SWDEV-253997 : packaging fix: installing hsa_ostream_ops.h
28e4b8e 
Change-Id: Ib739cbb7538473afc9744e12d2bd568635e78616
(cherry picked from commit 1d975e5)
SWDEV-251491 : gen_ostream_ops.py porting to python3
367e2c4 
Change-Id: I7081b6ad21b038040267067bd73d8a44df46e4ff
SWDEV-249924 : hip correlation id explicite propogation; tracer debug…
fb0c230 
… instrumentation;

Change-Id: Ibbc411541f5610ce739f3fc1efa1ab7f605220f5

initial commmit

Change-Id: I34b360be62c2083819dc5c3acc8268bd69f2f58a
SWDEV-258731 : cleanup
8bb2d30 
Change-Id: I0bc4ca977ce44f864178e78ec339888f86cbed8a
@pruthvistony-amd
Add RUNPATH to libtracer_tool.so
9f02bb9 
- All libs will have RUNPATH
- libtracer_tool.so is added with RUNPATH based on ROCM_RPATH when
  defined else not set.

Signed-off-by: Pruthvi Madugundu <[email protected]>
Change-Id: I6515e603c82e1360e03eca2967f6a85e5faadc9a
@nelsonc-amd
CMakeList.txt: conformant package names
73fb6ea 
Still needs valid email ID in the form of [email protected].
SWDEV-257322

Names complete as built (internal) :
roctracer-dev_1.0.0.40000-crdnnv.444_amd64.deb
roctracer-dev-1.0.0.40000-crdnnv.444.el7.x86_64.rpm

These changes are to satisfy:
http://confluence.amd.com/display/GPUCPT/Package+File+Naming

Change-Id: I5991326eb87d7dfa1304e3b2c5afb78f5a0c0361
Signed-off-by: Cole Nelson <[email protected]>
(cherry picked from commit 16ad4e9)
@parepate
SWDEV-251491 : disabling hipModuleUnload tracing which is called on exit
0876c25 
Change-Id: I99c22eec3fea6ac8820d574c44df099febdd27c4
(cherry picked from commit bb8f2f6)
@parepate
hip library loader check
18c83ea 
Change-Id: I34957db88932e1ed725a0a0d8ca9a66fecc92e38
(cherry picked from commit 9061c4e)
SWDEV-213367 : codeobj event implementation
d8d7137 
Change-Id: Ibcaca6869ce96d8802c5fa8ba241f43834d6f2a7

update - codeobj event implementation

Change-Id: I4c12f26a19f2b31d9ac2211c3426a0e587a332b3

update2 - codeobj event implementation

Change-Id: Ic877549a83542ae00352503471d881e847ebac9c

test - codeobj event implementation

Change-Id: I0618d3a93de94c3d7467372ba4a3d4ea5520bfc7

URI reference test - codeobj event implementation

Change-Id: I6cf7e8a648cf012cb0708058b118a75e58f992b9

adding test/app - codeobj event implementation

Change-Id: Idf4c197c7b9116ccde5ec50ff47a26a858bfab32

uri test fix - codeobj event implementation

Change-Id: I7c385f82f516d9d8f2cd726366f00be3664006e3

uri test cleanup - codeobj event implementation

Change-Id: I542d5baf88c048c8b4717af843b803cd93e8f3bc

URI buffer fix - codeobj event implementation

Change-Id: Iac65e04c03a0939935c10f53c6b580a2e33878f5

HSA events tests trace-check disabled

Change-Id: I0f4d13aeeceb1d1a6e2191673eacbf9c7ae2ae52
SWDEV-254329 : extending debug trace with timestamps, cmake option '-…
c163244 
…DCMAKE_DEBUG_TRACE=1'

Change-Id: Id16c01a6c00f6384c37fa9b5a9709a5e98e1fb57
code obj tests: adding load base
2293663 
Change-Id: I5fdb25b67eaae43b3c01cd8de3824f9343c37794
@rkebichi
SWDEV-255938 NEW - added regex and depth support to ostream ops
68b1850 
Change-Id: I292255adab3a70fa00a1dd5685b788521687f35b
adding tests dry run to check if platform is in working state
ff8ac19 
Change-Id: Ic430e3f959119983a65929fc70332e293cc3448d
Adding dumping of HSA handles
d4cd091 
Change-Id: I18e2cfdf2574110bffa09d30c7ac1d3941252939
SWDEV-264282 : fixing tracer_tool linking
bf70a1a 
Change-Id: I0fd78c01595bbd506f42cf9dfb45f62b2124f704
calling python3 explictely
bfb9095 
Change-Id: I3dda55865bafa41cc6670e414b213f13a2a2a7ac
@rkebichi
SWDEV-259683 HIP API records filtering
3c1a4b3 
Change-Id: I43ca5e022d2c055b6a9bc2c09b4276b490a4b986
SWDEV-251491 : disabling tracing on exit
36b1b2f 
Change-Id: Ifd5f0fbad70afa1e79da8b4b9aa639d899cbea76
SWDEV-251491 : fixing tracing on exit
7ea1e9a 
Change-Id: I1bf2a6093331e7a08179b9f64394c5c49206ef0e
@rkebichi
SWDEV-271503 Fixed core dump
2a64bd0 
Change-Id: Ia582a27482581c3b81c42da0add9f6743898da6c
@rkebichi
SWDEV-281008 replace hcc_detail by amd_detail
89ab109 
Change-Id: I180b18f9e1fae40c923d6210901f06cba14e8f13
amd-isparry and others added 19 commits July 13, 2021 19:49
@amd-isparry
Add dependency on rocm-core
e723f8c 
The intention is to make all rocm-packages depend on a tiny rocm-core
package so that all of rocm can be removed by removing
rocm-core. Obviously it is less than ideal that you install by using
some variant of "apt install rocm" and remove everything by "apt
remove rocm-core", but this is easy to document. The alternative "apt
autoremove rocm" may remove unrelated packages.

Signed-off-by: Icarus Sparry <[email protected]>
Change-Id: I74351c7be3c2d3dfec577d36ae78222b3fd22ef3
Signed-off-by: Icarus Sparry <[email protected]>
@chrispaquot @arjun-raj-kuppala
SWDEV-281658 - Preserve the callback IDs enum ordering
f7adedb 
Use HIP_API_ID_NONE to detect unsupported API instead of
HIP_API_ID_NUMBER which can grow with a new version of the API.
This HIP_API_ID_NONE enum has a fixed value of 0 so the
HIP_API_IDs really start at FIRST.

Change-Id: I760aa50ddf6fa6d46bf20555ad7d429335a53f97
Merge remote-tracking branch 'remotes/origin/amd-staging' into amd-ma…
c5c5e5d 
…ster

Change-Id: I501dc3617e081cba942d687e5ea9f370afcd4f87
Merge remote-tracking branch 'remotes/origin/amd-staging' into amd-ma…
ddb44e4 
…ster

Change-Id: Ic32b863299d09292bec1356c5e0436a194fa5d74
Merge remote-tracking branch 'remotes/origin/amd-staging' into amd-ma…
776eac1 
…ster

Change-Id: I2841ebfee63eb9b34f5c9bef36f3f787c7ef6e8d
Merge remote-tracking branch 'remotes/origin/amd-staging' into amd-ma…
fba52e8 
…ster

Change-Id: I21e3c999bc40c36b926140bb40aca2f6b6408948
@ammarwa
updating known issues
f32619b
Merge remote-tracking branch 'remotes/origin/amd-staging' into amd-ma…
bd6d6d3 
…ster

Change-Id: I7af234a02d143863c201a15cfd019a8bce8614b2
@ammarwa
SWDEV-318551: Adding License file for tracer
38a1972 
Making the new License file, Adding support in the CMakeLists.txt

Change-Id: I43862b8b7f3025ae6200aeb442ea70c7993a7349
Merge remote-tracking branch 'remotes/origin/amd-staging' into amd-ma…
c3cbdea 
…ster

Change-Id: Ie87fff9e4cdfd5d061d6ca09a623cbd9ef23efc5
Merge remote-tracking branch 'remotes/origin/amd-staging' into amd-ma…
da12ec5 
…ster

Change-Id: I477207eb2ae1874809e4323b58b5dcae58dc050f
@ammarwa
Update README.md
1668617
@ammarwa
Merge branch 'amd-master' into rocm-5.0.x
f6db80c 
Updating amd-master branch with latest updates from ROCm 5.0.0
@raramakr
SWDEV-291455: Prefer rocm include path to hip include path
a19a826 
Change-Id: I1fa96e72169fac689a3a2ed38e988d7f5d18bf04
(cherry picked from commit ebda880)
Merge remote-tracking branch 'remotes/origin/amd-staging' into amd-ma…
38397cb 
…ster

Change-Id: I8bed468b05991f5967fe6d9b9ff49ac45120f9cc
@ammarwa
Merge tag 'rocm-5.1.0' into amd-master
7f02d6e
@ammarwa
SWDEV-307394: Fixing Download HSA-Class Issue
75f74bb 
Exchanging the git clone of the hsa-class to a local downloaded version pushed to the roctracer repo

Change-Id: Id45a38b2d355102c2e0dee1e4bfde50398369047
(cherry picked from commit 7ee4f87)
@ammarwa
Merge remote-tracking branch 'origin/rocm-5.1.x' into amd-master
f935048
@MrBurmark
Fix memory leak in roctxRangePushA
82ceb54 
Do not strdup message when pushing to stack of std::strings.
Use emplace to avoid unnecessary std::string moves/copies.
@CRobeck CRobeck requested a review from ammarwa June 10, 2022 18:39
@MrBurmark
Copy link
Author

MrBurmark commented Jun 10, 2022 •
edited
Loading

Is the api_data message freed in the callback? Does it need to be strdup'd in the first place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammarwa ammarwa Awaiting requested review from ammarwa ammarwa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@MrBurmark @rkebichi @pruthvistony-amd @nelsonc-amd @amd-isparry @chrispaquot @ammarwa @raramakr