Fix crash when loading web UI roofline for gfx942 #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benrichard-amd
requested review from
coleramos425,
feizheng10 and
dgaliffiAMD
as code owners
Signed-off-by: benrichard-amd <[email protected]>
feizheng10
approved these changes
Nov 18, 2024
Signed-off-by: benrichard-amd <[email protected]>
Signed-off-by: benrichard-amd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An exception was thrown when loading the roofline chart in the Web UI for MI300.
Missing parameter when calling Roofline constructor, which caused the 3rd parameter to use a default value of None, resulting in an exception later in the code.