Skip to content

Commit

Permalink
Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu mo…
Browse files Browse the repository at this point in the history
…del solely based on chip id.
  • Loading branch information
xuchen-amd committed Sep 19, 2024
1 parent 9d7bc87 commit d7b9807
Showing 1 changed file with 4 additions and 17 deletions.
21 changes: 4 additions & 17 deletions src/omniperf_soc/soc_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,6 @@ def get_profiler_options(self):
# assume no SoC specific options and return empty list by default
return []

def check_arch_override(self):
if "OMNIPERF_ARCH_OVERRIDE" in os.environ.keys():
return os.environ["OMNIPERF_ARCH_OVERRIDE"]
return ""

@demarcate
def populate_mspec(self):
from utils.specs import search, run, total_sqc, total_xcds
Expand Down Expand Up @@ -185,18 +180,10 @@ def populate_mspec(self):
self._mspec.gpu_model = list(SUPPORTED_ARCHS[self._mspec.gpu_arch].keys())[
0
].upper()
if self._mspec.gpu_model == "MI300":
self._mspec.gpu_model = list(SUPPORTED_ARCHS[self._mspec.gpu_arch].values())[
0
][0]
# Use Chip ID to distinguish the gpu model by using built-in dictionary
if self._mspec.chip_id in MI300_CHIP_IDS:
self._mspec.chip_id = MI300_CHIP_IDS[self._mspec.chip_id]
else:
console_error(
"Cannot parse MI300 details from rocminfo. Please verify output or set the arch using (e.g.,) "
'export OMNIPERF_ARCH_OVERRIDE="MI300A"'
)
if self._mspec.gpu_model == "MI300":
# Use Chip ID to distinguish MI300 gpu model using the built-in dictionary
if self._mspec.chip_id in MI300_CHIP_IDS:
self._mspec.chip_id = MI300_CHIP_IDS[self._mspec.chip_id]

self._mspec.num_xcd = str(
total_xcds(self._mspec.gpu_model, self._mspec.compute_partition)
Expand Down

0 comments on commit d7b9807

Please sign in to comment.