Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README.md with standard Markdown tables, cleaned a bit header… #91

Closed
wants to merge 2 commits into from

Conversation

Maxzor
Copy link

@Maxzor Maxzor commented Jan 30, 2022

… levels.
#90

Elena Sakhnovitch and others added 2 commits October 4, 2021 15:04
signed-off-by: Elena Sakhnovitch
Change-Id: I265ba32bc3777db5f04f1924547fe432ba78c3d0
(cherry picked from commit 2f84906)
Copy link

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks quite nicer!
Thanks.

@@ -188,7 +188,7 @@ def getFanSpeed(device):
if rsmi_ret_ok(ret, device, None, True):
fm = fanMax.value
if fl == 0 or fm == 0:
return (fl, fm) # to prevent division by zero crash
return (fl, 0) # to prevent division by zero crash
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks outside the scope of a documentation change.

@dmitrii-galantsev dmitrii-galantsev changed the base branch from master to develop October 23, 2023 17:23
@dmitrii-galantsev
Copy link
Collaborator

looks like I broke something when trying to rebase using github GUI :)
I'll cherry-pick your change and apply myself. Should be in https://github.com/RadeonOpenCompute/rocm_smi_lib/tree/develop soon

@dmitrii-galantsev dmitrii-galantsev changed the base branch from develop to master October 23, 2023 21:03
@dmitrii-galantsev
Copy link
Collaborator

Merged 8cfcb51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants