Fix multi-version installation instruction #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexxu-amd
commented
Nov 5, 2024
•
alexxu-amd
commented
- Previous version used a loop to register the driver. It doesn't make sense since it is a overwrite operation. Change to use the latest version to register the driver
- Fixed an error in the rhel instruction ( name=ROCm|rocm_version|, only install the latest ROCm since rocm_version is static)
- Refactored SLES section for consistency
yhuiYH
reviewed
Nov 6, 2024
Co-authored-by: Young Hui - AMD <[email protected]>
|
Ram also wants Freddy to take a look before we publish. I'll ping him tomorrow |
rponnuru5
approved these changes
Nov 12, 2024
alexxu-amd
added a commit
that referenced
this pull request
Nov 13, 2024
* fix multi-version installation instruction * Update docs/install/native-install/includes/sles-multi-install.rst Co-authored-by: Young Hui - AMD <[email protected]> --------- Co-authored-by: Young Hui - AMD <[email protected]> (cherry picked from commit fe89acc)
alexxu-amd
added a commit
that referenced
this pull request
Nov 13, 2024
* fix multi-version installation instruction * Update docs/install/native-install/includes/sles-multi-install.rst Co-authored-by: Young Hui - AMD <[email protected]> --------- Co-authored-by: Young Hui - AMD <[email protected]> (cherry picked from commit fe89acc)
alexxu-amd
added a commit
that referenced
this pull request
Nov 13, 2024
* fix multi-version installation instruction * Update docs/install/native-install/includes/sles-multi-install.rst Co-authored-by: Young Hui - AMD <[email protected]> --------- Co-authored-by: Young Hui - AMD <[email protected]>
alexxu-amd
added a commit
that referenced
this pull request
Nov 13, 2024
* fix multi-version installation instruction * Update docs/install/native-install/includes/sles-multi-install.rst Co-authored-by: Young Hui - AMD <[email protected]> --------- Co-authored-by: Young Hui - AMD <[email protected]> (cherry picked from commit fe89acc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.